* [PATCH RFT] clk: qcom: lcc-ipq806x: Fixup overriding val in regmap_read call
@ 2016-09-10 3:47 Axel Lin
2016-09-12 22:34 ` Stephen Boyd
2016-11-02 0:44 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-09-10 3:47 UTC (permalink / raw)
To: Stephen Boyd
Cc: Michael Turquette, Andy Gross, Rajendra Nayak, Kevin Hilman,
linux-arm-msm, linux-clk, Axel Lin
Drop the assignment of regmap_read return code to val, so the code checks
the value read.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/clk/qcom/lcc-ipq806x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/lcc-ipq806x.c b/drivers/clk/qcom/lcc-ipq806x.c
index db3998e..977e98e 100644
--- a/drivers/clk/qcom/lcc-ipq806x.c
+++ b/drivers/clk/qcom/lcc-ipq806x.c
@@ -443,7 +443,7 @@ static int lcc_ipq806x_probe(struct platform_device *pdev)
return PTR_ERR(regmap);
/* Configure the rate of PLL4 if the bootloader hasn't already */
- val = regmap_read(regmap, 0x0, &val);
+ regmap_read(regmap, 0x0, &val);
if (!val)
clk_pll_configure_sr(&pll4, regmap, &pll4_config, true);
/* Enable PLL4 source on the LPASS Primary PLL Mux */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] clk: qcom: lcc-ipq806x: Fixup overriding val in regmap_read call
2016-09-10 3:47 [PATCH RFT] clk: qcom: lcc-ipq806x: Fixup overriding val in regmap_read call Axel Lin
@ 2016-09-12 22:34 ` Stephen Boyd
2016-11-02 0:44 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-09-12 22:34 UTC (permalink / raw)
To: Axel Lin
Cc: Michael Turquette, Andy Gross, Rajendra Nayak, Kevin Hilman,
linux-arm-msm, linux-clk
On 09/10, Axel Lin wrote:
> Drop the assignment of regmap_read return code to val, so the code checks
> the value read.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Looks obviously correct. I'll have to dig up the hardware to test
it though so I'm considering just applying it directly and
assuming there won't be any fallout.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] clk: qcom: lcc-ipq806x: Fixup overriding val in regmap_read call
2016-09-10 3:47 [PATCH RFT] clk: qcom: lcc-ipq806x: Fixup overriding val in regmap_read call Axel Lin
2016-09-12 22:34 ` Stephen Boyd
@ 2016-11-02 0:44 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-11-02 0:44 UTC (permalink / raw)
To: Axel Lin
Cc: Michael Turquette, Andy Gross, Rajendra Nayak, Kevin Hilman,
linux-arm-msm, linux-clk
On 09/10, Axel Lin wrote:
> Drop the assignment of regmap_read return code to val, so the code checks
> the value read.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
I never got around to testing it, but it looks correct enough.
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-02 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-10 3:47 [PATCH RFT] clk: qcom: lcc-ipq806x: Fixup overriding val in regmap_read call Axel Lin
2016-09-12 22:34 ` Stephen Boyd
2016-11-02 0:44 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).