From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Brown <david.brown@linaro.org>
Subject: Re: [PATCH 2/2] ARM: dts: add SMSC ethernet on the APQ8060 Dragonboard
Date: Tue, 18 Oct 2016 17:52:57 -0700 [thread overview]
Message-ID: <20161019005257.GU8871@codeaurora.org> (raw)
In-Reply-To: <1476775542-4540-1-git-send-email-linus.walleij@linaro.org>
On 10/18, Linus Walleij wrote:
> @@ -167,6 +190,41 @@
> bias-pull-up;
> };
> };
> +
> + dragon_ebi2_pins: ebi2 {
> + /*
> + * Pins used by EBI2 on the Dragonboard, actually only
> + * only CS2 is used by a real peripheral. CS0 is just
> + * routed to a test point.
> + */
> + mux0 {
> + /*
> + * Pins used by EBI2 on the Dragonboard, actually only
> + * only CS2 is used by a real peripheral. CS0 is just
> + * routed to a test point.
> + */
Same comment twice? Plus it says "only only CS2", so we probably
want to drop one "only".
> + pins =
> + /* "gpio39", CS1A_N this is not good to mux */
> + "gpio40", /* CS2A_N */
> + "gpio134"; /* CS0_N testpoint TP29 */
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-19 0:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:25 [PATCH 2/2] ARM: dts: add SMSC ethernet on the APQ8060 Dragonboard Linus Walleij
2016-10-19 0:52 ` Stephen Boyd [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-08 13:41 Linus Walleij
2016-09-08 13:52 ` Arnd Bergmann
2016-09-08 14:03 ` Linus Walleij
2016-09-08 14:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019005257.GU8871@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).