From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 2/2] ARM: dts: add SMSC ethernet on the APQ8060 Dragonboard Date: Tue, 18 Oct 2016 17:52:57 -0700 Message-ID: <20161019005257.GU8871@codeaurora.org> References: <1476775542-4540-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:36633 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751981AbcJSAw6 (ORCPT ); Tue, 18 Oct 2016 20:52:58 -0400 Content-Disposition: inline In-Reply-To: <1476775542-4540-1-git-send-email-linus.walleij@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , David Brown On 10/18, Linus Walleij wrote: > @@ -167,6 +190,41 @@ > bias-pull-up; > }; > }; > + > + dragon_ebi2_pins: ebi2 { > + /* > + * Pins used by EBI2 on the Dragonboard, actually only > + * only CS2 is used by a real peripheral. CS0 is just > + * routed to a test point. > + */ > + mux0 { > + /* > + * Pins used by EBI2 on the Dragonboard, actually only > + * only CS2 is used by a real peripheral. CS0 is just > + * routed to a test point. > + */ Same comment twice? Plus it says "only only CS2", so we probably want to drop one "only". > + pins = > + /* "gpio39", CS1A_N this is not good to mux */ > + "gpio40", /* CS2A_N */ > + "gpio134"; /* CS0_N testpoint TP29 */ -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project