From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Date: Wed, 9 Nov 2016 17:49:08 -0800 Message-ID: <20161110014908.GZ16026@codeaurora.org> References: <1478218237-1737-1-git-send-email-spjoshi@codeaurora.org> <1478218237-1737-4-git-send-email-spjoshi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1478218237-1737-4-git-send-email-spjoshi@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Sarangdhar Joshi Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Jordan Crouse , Trilok Soni List-Id: linux-arm-msm@vger.kernel.org On 11/03, Sarangdhar Joshi wrote: > When devm_clk_get fails for core clock, the failure was ignored > and the core_clk was explicitly set to NULL so that other > remaining clocks can be queried. However, now that we have a > cleaner way of expressing the clock dependency, return failure > when devm_clk_get fails for core clock. > > Signed-off-by: Sarangdhar Joshi Why can't this be folded into the second patch? It seems incorrect to allow it to silently work in patch 2 even though we've flagged that clk as a requirement and then change that behavior here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project