From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency Date: Thu, 10 Nov 2016 15:17:22 -0800 Message-ID: <20161110231722.GL16026@codeaurora.org> References: <1478218237-1737-1-git-send-email-spjoshi@codeaurora.org> <1478218237-1737-3-git-send-email-spjoshi@codeaurora.org> <20161110014718.GY16026@codeaurora.org> <20161110055507.GD11179@tuxbot> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161110055507.GD11179@tuxbot> Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: Sarangdhar Joshi , Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jordan Crouse , Trilok Soni List-Id: linux-arm-msm@vger.kernel.org On 11/09, Bjorn Andersson wrote: > On Wed 09 Nov 17:47 PST 2016, Stephen Boyd wrote: > > > On 11/03, Sarangdhar Joshi wrote: > > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > > > index d79fecd..844e90d 100644 > > > --- a/drivers/firmware/qcom_scm.c > > > +++ b/drivers/firmware/qcom_scm.c > > > @@ -380,32 +384,40 @@ EXPORT_SYMBOL(qcom_scm_is_available); > > > static int qcom_scm_probe(struct platform_device *pdev) > > > { > > > struct qcom_scm *scm; > > > + uint32_t clks; > > > > If this was unsigned long flags; > > > > I did look at this too and could only find a mixture of ways people have > done this. Isn't the correct type for this intptr_t? > Well unsigned long == sizeof(kernel pointer) on all Linux platforms so it's safe to do the cast. For example, struct timer_list stores data in unsigned long. I guess this is a 'kernelism' though? Perhaps we should update Documentation/CodingStyle if anyone cares. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project