From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v4 00/10]remoteproc: qcom: Add support to hexagon q6v56 in qcom hexagon rproc driver Date: Wed, 16 Nov 2016 15:03:39 -0800 Message-ID: <20161116230339.GM25626@codeaurora.org> References: <1479315696-15490-1-git-send-email-akdwived@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43264 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbcKPXDl (ORCPT ); Wed, 16 Nov 2016 18:03:41 -0500 Content-Disposition: inline In-Reply-To: <1479315696-15490-1-git-send-email-akdwived@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Avaneesh Kumar Dwivedi Cc: bjorn.andersson@linaro.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On 11/16, Avaneesh Kumar Dwivedi wrote: > This is patchset v4 having modifications as per comment on patchset v3. > Major changes w.r.t. patchset v3 are as below. > 1- clean up of resource struct initialization. > 2- breaking up all changes into more number of logical patches. > 3- handling of clock through array of clock pointers. > 4- single place handling of proxy and active regulators. > 5- Addressing Other comments on last patches. > > There were certain comments which could not be addressed > 1- To program MSS_RESET via GCC reset controller > Since MSS_RESET does not control any clock as are done by other BCR or block control > registers, so it does not qualify to be controlled by GCC reset controller. > This is moreover like any other register, which can be programmed by IOREMAP. Sorry I don't understand this reasoning at all. If MSS_RESET lives in GCC, then it should be exposed as a reset through the linux kernel reset APIs. It doesn't matter if that reset controls or doesn't control a clock in the hardware implementation. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project