From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Date: Fri, 18 Nov 2016 10:35:41 -0800 Message-ID: <20161118183541.GI28340@tuxbot> References: <1479190014-11297-1-git-send-email-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kalle Valo Cc: Eugene Krasnikov , Kalle Valo , Andy Gross , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: > Bjorn Andersson wrote: > > The correct include file for getting errno constants and ERR_PTR() is > > linux/err.h, rather than linux/errno.h, so fix the include. > > > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") > > Acked-by: Andy Gross > > Signed-off-by: Bjorn Andersson > > For some reason this fails to compile now. Can you take a look, please? > > ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > 5 patches set to Changes Requested. > > 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() > 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client This patch was updated with the necessary depends in Kconfig to catch this exact issue and when I pull in your .config (which has QCOM_SMD=n, QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine. I've tested the various combinations and it seems to work fine. Do you have any other patches in your tree? Any stale objects? Would you mind retesting this, before I invest more time in trying to reproduce the issue you're seeing? Regards, Bjorn