From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [RESEND PATCH v2] remoteproc: qcom: Add venus rproc support on msm8996 platform. Date: Tue, 29 Nov 2016 11:27:02 -0800 Message-ID: <20161129192702.GA6095@codeaurora.org> References: <1480416647-3518-1-git-send-email-akdwived@codeaurora.org> <1480416647-3518-2-git-send-email-akdwived@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37672 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755923AbcK2T1E (ORCPT ); Tue, 29 Nov 2016 14:27:04 -0500 Content-Disposition: inline In-Reply-To: <1480416647-3518-2-git-send-email-akdwived@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Avaneesh Kumar Dwivedi Cc: bjorn.andersson@linaro.org, stanimir.varbanov@linaro.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On 11/29, Avaneesh Kumar Dwivedi wrote: > This patch is based on > https://patchwork.kernel.org/patch/9415627/ > https://patchwork.kernel.org/patch/9415651/ > > This patch add clock initialization, enable and disable support. > Required resource name string and rating are differentiated based > on compatible string. Also added documentation for venus pil on > msm8996. > > Signed-off-by: Avaneesh Kumar Dwivedi > --- > .../devicetree/bindings/remoteproc/qcom,venus.txt | 26 ++++- > drivers/remoteproc/qcom_venus_pil.c | 116 ++++++++++++++++++++- > 2 files changed, 140 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt > index 2d73ba1..417026b 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt > @@ -6,13 +6,30 @@ on the Qualcomm Venus remote processor core. > - compatible: > Usage: required > Value type: > - Definition: must contain "qcom,venus-pil" > + Definition: must contain "qcom,venus-pil" or > + "qcom,venus-msm8996-pil" > > - memory-region: > Usage: required > Value type: > Definition: a phandle to a node describing reserved memory > > +- clocks: > + Usage: required > + Value type: > + Definition: reference to the core, iface and bus and maxi clocks to be held on > + behalf of the booting of the venus core > + > +- clock-names: > + Usage: required > + Value type: > + Definition: should be "core_clk", "iface_clk", "bus_clk", "maxi_clk" Please drop _clk from all clock names. > + > +- power-domains: > + Usage: required > + Value type: > + Definition: reference to the venus gdsc to be turned on before booting venus core All these new properties can't be required if the original compatible is used, right? > + > * An example > reserved-memory { > #address-cells = <2>; > @@ -29,5 +46,12 @@ on the Qualcomm Venus remote processor core. > > rproc_venus@0 { > compatible = "qcom,venus-pil"; > + clocks = <&mmcc VIDEO_CORE_CLK>, > + <&mmcc VIDEO_AHB_CLK>, > + <&mmcc VIDEO_AXI_CLK>, > + <&mmcc VIDEO_MAXI_CLK>; > + > + clock-names = "core_clk", "iface_clk", "bus_clk", "maxi_clk"; > + power-domains = <&mmcc VENUS_GDSC>; > memory-region = <&venus_mem>; > }; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project