From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RESEND PATCH v4 7/7] clk: qcom: Add GCC_MSS_RESET support to reset MSS in v56 1.5.0 Date: Thu, 8 Dec 2016 11:51:30 -0800 Message-ID: <20161208195130.GN30492@tuxbot> References: <1479981638-32069-1-git-send-email-akdwived@codeaurora.org> <1479981638-32069-8-git-send-email-akdwived@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:35346 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbcLHTvf (ORCPT ); Thu, 8 Dec 2016 14:51:35 -0500 Received: by mail-pg0-f41.google.com with SMTP id p66so177161420pga.2 for ; Thu, 08 Dec 2016 11:51:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <1479981638-32069-8-git-send-email-akdwived@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Avaneesh Kumar Dwivedi Cc: sboyd@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On Thu 24 Nov 02:00 PST 2016, Avaneesh Kumar Dwivedi wrote: > Add support to use reset control framework for resetting MSS > on v56 1.5.0. > > Signed-off-by: Avaneesh Kumar Dwivedi You should try (really hard) to limit your subject line to 50 characters and then use the body to describe your change - rather than just typing the same thing twice. E.g. a subject of "clk: gcc-msm8996: Add MSS_RESET" is short and to the point. Please update the subject and add: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/clk/qcom/gcc-msm8996.c | 1 + > include/dt-bindings/clock/qcom,gcc-msm8996.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c > index fe03e6f..fd4bf6f 100644 > --- a/drivers/clk/qcom/gcc-msm8996.c > +++ b/drivers/clk/qcom/gcc-msm8996.c > @@ -3423,6 +3423,7 @@ enum { > [GCC_MSMPU_BCR] = { 0x8d000 }, > [GCC_MSS_Q6_BCR] = { 0x8e000 }, > [GCC_QREFS_VBG_CAL_BCR] = { 0x88020 }, > + [GCC_MSS_RESTART] = { 0x8f008 }, > }; > > static const struct regmap_config gcc_msm8996_regmap_config = { > diff --git a/include/dt-bindings/clock/qcom,gcc-msm8996.h b/include/dt-bindings/clock/qcom,gcc-msm8996.h > index 1828723..1f5c422 100644 > --- a/include/dt-bindings/clock/qcom,gcc-msm8996.h > +++ b/include/dt-bindings/clock/qcom,gcc-msm8996.h > @@ -339,6 +339,7 @@ > #define GCC_PCIE_PHY_COM_NOCSR_BCR 102 > #define GCC_USB3_PHY_BCR 103 > #define GCC_USB3PHY_PHY_BCR 104 > +#define GCC_MSS_RESTART 105 > > > /* Indexes for GDSCs */ > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project. >