From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RESEND PATCH v4 6/7] remoteproc: qcom: Modify stop routine to limit MX current for v56 1.5 Date: Thu, 8 Dec 2016 20:42:41 -0800 Message-ID: <20161209044241.GT30492@tuxbot> References: <1479981638-32069-1-git-send-email-akdwived@codeaurora.org> <1479981638-32069-7-git-send-email-akdwived@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f176.google.com ([209.85.192.176]:35326 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbcLIEmr (ORCPT ); Thu, 8 Dec 2016 23:42:47 -0500 Received: by mail-pf0-f176.google.com with SMTP id i88so1681145pfk.2 for ; Thu, 08 Dec 2016 20:42:47 -0800 (PST) Content-Disposition: inline In-Reply-To: <1479981638-32069-7-git-send-email-akdwived@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Avaneesh Kumar Dwivedi Cc: sboyd@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On Thu 24 Nov 02:00 PST 2016, Avaneesh Kumar Dwivedi wrote: > For v56 1.5.0 Mx current need to be limited during restart. > > Signed-off-by: Avaneesh Kumar Dwivedi > --- > drivers/remoteproc/qcom_q6v5_pil.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c > index 7ea2f53..3e3ed09 100644 > --- a/drivers/remoteproc/qcom_q6v5_pil.c > +++ b/drivers/remoteproc/qcom_q6v5_pil.c > @@ -785,7 +785,7 @@ static int q6v5_start(struct rproc *rproc) > static int q6v5_stop(struct rproc *rproc) > { > struct q6v5 *qproc = (struct q6v5 *)rproc->priv; > - int ret; > + int ret, val; One variable per line, please. > > qproc->running = false; > > @@ -803,6 +803,22 @@ static int q6v5_stop(struct rproc *rproc) > q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_modem); > q6v5proc_halt_axi_port(qproc, qproc->halt_map, qproc->halt_nc); > > + if (qproc->hexagon_ver & 0x2) { Compare with == and use the enum. > + /* > + * Assert QDSP6 I/O clamp, memory wordline clamp, and compiler > + * memory clamp as a software workaround to avoid high MX > + * current during LPASS/MSS restart. > + */ I'm not sure if you answered this (or if I forgot to ask), is this something we only want to do on the latest version? > + ret = clk_prepare_enable(devm_clk_get(qproc->dev, "iface")); "iface" is part of your active set, so it should still be enabled. > + if (!ret) { > + val = readl_relaxed( > + qproc->reg_base + QDSP6SS_PWR_CTL_REG); Please use non-_relaxed versions. > + val |= (Q6SS_CLAMP_IO | QDSP6v56_CLAMP_WL | > + QDSP6v56_CLAMP_QMC_MEM); No need for the parenthesis around this expression. > + writel_relaxed(val, > + qproc->reg_base + QDSP6SS_PWR_CTL_REG); > + } > + } Regards, Bjorn