From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RESEND PATCH v4 5/7] remoteproc: qcom: Modify reset sequence for hexagon to support v56 1.5.0 Date: Wed, 14 Dec 2016 12:13:52 -0800 Message-ID: <20161214201352.GO3439@tuxbot> References: <1479981638-32069-1-git-send-email-akdwived@codeaurora.org> <1479981638-32069-6-git-send-email-akdwived@codeaurora.org> <20161209043510.GS30492@tuxbot> <0f3dbcbb-4ed5-dac8-a9c7-a22d597f4be5@codeaurora.org> <20161213180924.GG3439@tuxbot> <20161213220730.GK3439@tuxbot> <8817f22c-b0bb-f560-89ce-0c71aca45320@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f177.google.com ([209.85.192.177]:36135 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933269AbcLNUN4 (ORCPT ); Wed, 14 Dec 2016 15:13:56 -0500 Received: by mail-pf0-f177.google.com with SMTP id 189so5072414pfz.3 for ; Wed, 14 Dec 2016 12:13:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <8817f22c-b0bb-f560-89ce-0c71aca45320@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Dwivedi, Avaneesh Kumar (avani)" Cc: sboyd@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org On Wed 14 Dec 07:50 PST 2016, Dwivedi, Avaneesh Kumar (avani) wrote: > > > On 12/14/2016 3:37 AM, Bjorn Andersson wrote: > >On Tue 13 Dec 11:45 PST 2016, Dwivedi, Avaneesh Kumar (avani) wrote: > >>On 12/13/2016 11:39 PM, Bjorn Andersson wrote: > >[..] > >>>Either way, using the non-_relaxed version of writel() will be > >>>equivalent to what you have now. > >>Do you mean if writel is used , udelay() should be removed? > >No, I mean that looping writel_relaxed() + wmb() is roughly > >equivalent to writel(). So with the overall comment of you replacing > >readl_relaxed() and writel_relaxed() with their plain readl/writel > >counterparts takes care of the wmb(). > > Thanks got it, yes my requirement was to get write done before control > reaches udelay(), so i will add readl() before udelay and remove mb() Sounds good. > I hope after this change i can submit next set of patches? Yes, please do. Regards, Bjorn