From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v5 3/7] remoteproc: qcom: Add and initialize proxy and active regulators. Date: Wed, 28 Dec 2016 15:38:43 -0800 Message-ID: <20161228233843.GF17126@codeaurora.org> References: <1481804490-8583-1-git-send-email-akdwived@codeaurora.org> <1481804490-8583-4-git-send-email-akdwived@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35756 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcL1Xip (ORCPT ); Wed, 28 Dec 2016 18:38:45 -0500 Content-Disposition: inline In-Reply-To: <1481804490-8583-4-git-send-email-akdwived@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Avaneesh Kumar Dwivedi Cc: bjorn.andersson@linaro.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org On 12/15, Avaneesh Kumar Dwivedi wrote: > @@ -148,29 +167,34 @@ enum { > Q6V5_SUPPLY_PLL, > }; > > -static int q6v5_regulator_init(struct q6v5 *qproc) > +static int q6v5_regulator_init(struct device *dev, struct reg_info *regs, > + const struct qcom_mss_reg_res *reg_res) > { > - int ret; > + int count = 0; > + int rc; > + int i; > > - qproc->supply[Q6V5_SUPPLY_CX].supply = "cx"; > - qproc->supply[Q6V5_SUPPLY_MX].supply = "mx"; > - qproc->supply[Q6V5_SUPPLY_MSS].supply = "mss"; > - qproc->supply[Q6V5_SUPPLY_PLL].supply = "pll"; > + while (reg_res[count].supply) > + count++; Indent that count++ please. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project