From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [bug report] remoteproc: qcom: mdt_loader: Refactor MDT loader Date: Tue, 14 Feb 2017 11:26:14 +0300 Message-ID: <20170214082614.GA7261@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:37523 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdBNI0X (ORCPT ); Tue, 14 Feb 2017 03:26:23 -0500 Content-Disposition: inline Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: bjorn.andersson@linaro.org Cc: linux-arm-msm@vger.kernel.org Hello Bjorn Andersson, The patch 7f0dd07a9b29: "remoteproc: qcom: mdt_loader: Refactor MDT loader" from Jan 27, 2017, leads to the following static checker warning: drivers/soc/qcom/mdt_loader.c:171 qcom_mdt_load() warn: unsigned 'offset' is never less than zero. drivers/soc/qcom/mdt_loader.c 164 for (i = 0; i < ehdr->e_phnum; i++) { 165 phdr = &phdrs[i]; 166 167 if (!mdt_phdr_valid(phdr)) 168 continue; 169 170 offset = phdr->p_paddr - mem_reloc; 171 if (offset < 0 || offset + phdr->p_memsz > mem_size) { ^^^^^^^^^^ offset is size_t. 172 dev_err(dev, "segment outside memory range\n"); 173 ret = -EINVAL; 174 break; 175 } 176 regards, dan carpenter