* [bug report] remoteproc: qcom: mdt_loader: Refactor MDT loader
@ 2017-02-14 8:26 Dan Carpenter
2017-02-14 8:27 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-02-14 8:26 UTC (permalink / raw)
To: bjorn.andersson; +Cc: linux-arm-msm
Hello Bjorn Andersson,
The patch 7f0dd07a9b29: "remoteproc: qcom: mdt_loader: Refactor MDT
loader" from Jan 27, 2017, leads to the following static checker
warning:
drivers/soc/qcom/mdt_loader.c:171 qcom_mdt_load()
warn: unsigned 'offset' is never less than zero.
drivers/soc/qcom/mdt_loader.c
164 for (i = 0; i < ehdr->e_phnum; i++) {
165 phdr = &phdrs[i];
166
167 if (!mdt_phdr_valid(phdr))
168 continue;
169
170 offset = phdr->p_paddr - mem_reloc;
171 if (offset < 0 || offset + phdr->p_memsz > mem_size) {
^^^^^^^^^^
offset is size_t.
172 dev_err(dev, "segment outside memory range\n");
173 ret = -EINVAL;
174 break;
175 }
176
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] remoteproc: qcom: mdt_loader: Refactor MDT loader
2017-02-14 8:26 [bug report] remoteproc: qcom: mdt_loader: Refactor MDT loader Dan Carpenter
@ 2017-02-14 8:27 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-02-14 8:27 UTC (permalink / raw)
To: bjorn.andersson; +Cc: linux-arm-msm
Also:
drivers/remoteproc/qcom_q6v5_pil.c:552 q6v5_mpss_load()
warn: unsigned 'offset' is never less than zero.
regards,
dan carpenter
On Tue, Feb 14, 2017 at 11:26:14AM +0300, Dan Carpenter wrote:
> Hello Bjorn Andersson,
>
> The patch 7f0dd07a9b29: "remoteproc: qcom: mdt_loader: Refactor MDT
> loader" from Jan 27, 2017, leads to the following static checker
> warning:
>
> drivers/soc/qcom/mdt_loader.c:171 qcom_mdt_load()
> warn: unsigned 'offset' is never less than zero.
>
> drivers/soc/qcom/mdt_loader.c
> 164 for (i = 0; i < ehdr->e_phnum; i++) {
> 165 phdr = &phdrs[i];
> 166
> 167 if (!mdt_phdr_valid(phdr))
> 168 continue;
> 169
> 170 offset = phdr->p_paddr - mem_reloc;
> 171 if (offset < 0 || offset + phdr->p_memsz > mem_size) {
> ^^^^^^^^^^
> offset is size_t.
>
> 172 dev_err(dev, "segment outside memory range\n");
> 173 ret = -EINVAL;
> 174 break;
> 175 }
> 176
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 8:26 [bug report] remoteproc: qcom: mdt_loader: Refactor MDT loader Dan Carpenter
2017-02-14 8:27 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).