From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Jonathan Neusch?fer <j.neuschaefer-hi6Y0CQ0nG0@public.gmane.org>
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: qcom_defconfig: Enable Qualcomm remoteproc and SMP2P drivers
Date: Sun, 5 Mar 2017 16:49:30 +0000 [thread overview]
Message-ID: <20170305164930.GA49943@Bjorns-MacBook-Pro-2.local> (raw)
In-Reply-To: <20170305050125.b6lzx2fiest4xmre@latitude>
On Sun 05 Mar 05:01 GMT 2017, Jonathan Neusch?fer wrote:
> On Fri, Mar 03, 2017 at 05:20:32PM -0800, Bjorn Andersson wrote:
> > On Tue 14 Feb 20:51 PST 2017, Jonathan Neusch?fer wrote:
> >
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer-hi6Y0CQ0nG0@public.gmane.org>
> > > ---
> > > arch/arm/configs/qcom_defconfig | 5 +++++
> > > 1 file changed, 5 insertions(+)
> [...]
> > > +CONFIG_QCOM_SMP2P=y
> >
> > We also need CONFIG_QCOM_SMSM=y here, its currently used to signal state
> > of the ring buffers for WiFi.
>
> FWIW, I enabled CONFIG_QCOM_SMSM on my test system (an Asus Padfone,
> based on MSM8974; I'm using the Sony Xperia Honami DT because it's close
> enough), and I think it failed to initialize:
>
Using Honami should work so far, but please do write a patch adding the
Padfone, so that we don't accidentally break your HW at some point.
> [ 0.647743] qcom-smsm smsm: no smsm size info, using defaults
> [ 0.647775] qcom-smsm smsm: unable to allocate shared state entry
>
Could you please confirm where in qcom_smem_alloc_global() we're
failing? As far as I can tell we should fail with -EEXIST or if the
passed "size" parameter is bogus -ENOMEM (but the default number of
entries really should be less than the amount of free SMEM space).
> I think CONFIG_QCOM_WCNSS_CTRL may be needed too, but I'll leave that
> for a future patch because I don't understand WCNSS well enough.
>
Missed that one, when the WCNSS firmware boots the WCNSS_CTRL driver is
probed - it will upload the NV parameter file to the WCNSS "OS" and when
that is done it will probe the WiFi and BT drivers.
So, you need it as well.
> > With the addition of that you have my:
> >
> > Acked-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> I'll send a v2 of this series with your R-b and A-b tags.
>
Thanks,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-05 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 4:51 [PATCH 1/2] ARM: dts: msm8974: Hook up adsp-pil's xo clock Jonathan Neuschäfer
[not found] ` <20170215045157.11659-1-j.neuschaefer-hi6Y0CQ0nG0@public.gmane.org>
2017-02-15 4:51 ` [PATCH 2/2] ARM: qcom_defconfig: Enable Qualcomm remoteproc and SMP2P drivers Jonathan Neuschäfer
[not found] ` <20170215045157.11659-2-j.neuschaefer-hi6Y0CQ0nG0@public.gmane.org>
2017-03-04 1:20 ` Bjorn Andersson
2017-03-05 5:01 ` Jonathan Neuschäfer
2017-03-05 16:49 ` Bjorn Andersson [this message]
2017-03-07 2:01 ` Jonathan Neuschäfer
2017-03-07 11:04 ` Bjorn Andersson
2017-03-09 3:01 ` Jonathan Neuschäfer
2017-02-20 22:00 ` [PATCH 1/2] ARM: dts: msm8974: Hook up adsp-pil's xo clock Andy Gross
2017-02-21 5:45 ` Bjorn Andersson
2017-02-21 16:29 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170305164930.GA49943@Bjorns-MacBook-Pro-2.local \
--to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=j.neuschaefer-hi6Y0CQ0nG0@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox