From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 1/2] ARM: dts: add SDC2 and SDC4 to the MSM8660 family Date: Mon, 6 Mar 2017 06:35:42 -0800 Message-ID: <20170306143542.GY25384@codeaurora.org> References: <20170306080029.3422-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40964 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754706AbdCFOf4 (ORCPT ); Mon, 6 Mar 2017 09:35:56 -0500 Content-Disposition: inline In-Reply-To: <20170306080029.3422-1-linus.walleij@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , David Brown On 03/06, Linus Walleij wrote: > To make the picture complete, add DTS entries also for the > second and fourth MMC/SD blocks on the MSM8660. SDC2 is > an 8-bit interface and SDC4 is a 4-bit interface. > > Signed-off-by: Linus Walleij > --- > arch/arm/boot/dts/qcom-msm8660.dtsi | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi > index 91c9a62ae725..5564ad131325 100644 > --- a/arch/arm/boot/dts/qcom-msm8660.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi > @@ -392,6 +392,22 @@ > cap-mmc-highspeed; > }; > > + sdcc2: sdcc@12140000 { > + status = "disabled"; > + compatible = "arm,pl18x", "arm,primecell"; > + arm,primecell-periphid = <0x00051180>; > + reg = <0x12140000 0x8000>; > + interrupts = ; > + interrupt-names = "cmd_irq"; > + clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>; > + clock-names = "mclk", "apb_pclk"; > + bus-width = <8>; > + max-frequency = <48000000>; > + non-removable; Should things like non-removable or max-frequency be specified in the base dts? Those seem like board attributes. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project