From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: MSM8974: USB (gadget mode) broken in v4.11-rc1 Date: Wed, 8 Mar 2017 09:40:55 +0100 Message-ID: <20170308084055.GA3093@hector> References: <20170307050423.njs6423sxmqbhrxn@latitude> <148890206102.8530.1859126261242834013@sboyd-linaro> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:33229 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbdCHImW (ORCPT ); Wed, 8 Mar 2017 03:42:22 -0500 Received: by mail-wm0-f52.google.com with SMTP id v203so14578495wmg.0 for ; Wed, 08 Mar 2017 00:40:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <148890206102.8530.1859126261242834013@sboyd-linaro> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Bjorn Andersson , Peter Chen , linux-arm-msm@vger.kernel.org On Tue, Mar 07, 2017 at 07:54:21AM -0800, Stephen Boyd wrote: > Quoting Jonathan Neuschäfer (2017-03-06 21:04:23) > > Hi, > > > > In Andy Gross' for-next branch (commit a844f941617c929b29, "Merge tag > > 'qcom-arm64-for-4.11-2' into final-for-4.11"), USB support on my MSM8974 > > phone worked, but since the following merge by Linus (195849ea13549dc), it > > does not work anymore. (I've only tested gadget mode so far. I don't know if > > host mode works.) > > > > I ran git bisect with the devicetree from Bjorn Andersson's commit > > 769907ae6e6c28 ("ARM: dts: qcom: msm8974: Add USB gadget nodes"), and got > > I have no idea why this was merged into v4.11-rc1. Andy? This was one of the outstanding patches that I thought needed to be merged. > > > this result: > > > > e9f15a71f17b328be44767cb893576c7c838f996 is the first bad commit > > commit e9f15a71f17b328be44767cb893576c7c838f996 > > Author: Stephen Boyd > > Date: Wed Dec 28 14:57:01 2016 -0800 > > > > usb: chipidea: msm: Add proper clk and reset support > > > > The msm chipidea controller uses two main clks, an AHB clk to > > read/write the MMIO registers and a core clk called the system > > clk that drives the controller itself. Add support for these clks > > as they're required in all designs. > > > > Also add support for an optional third clk that we need to turn > > on to reset the controller and wrapper logic and other > > "housekeeping" things. This clk was removed in later revisions of > > the hardware because the reset methodology no longer required > > clks to be enabled to propagate resets. > > > > Acked-by: Peter Chen > > Cc: Greg Kroah-Hartman > > Signed-off-by: Stephen Boyd > > Signed-off-by: Peter Chen > > > > I can't see any potential error messages because the serial gadget driver is > > the only console I have on this system. > > Oh that's unfortunate. > > > > > Is there something missing in qcom-msm8974.dtsi? > > Yes. The DT side of the patches never merged into arm-soc, so you'll > need this patch[1] to get things going. I thought the plan was to wait > for the usb driver rewrite and never merge that dts patch you mentioned. When I queued that into my set of patches I thought that it was safe. I thought wrong. I can send a fixes pull request to fix the current mainline. > [1] http://lkml.kernel.org/r/20170127004728.22490-4-stephen.boyd@linaro.org > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html