From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: linux-arm-msm@vger.kernel.org
Cc: "Bjorn Andersson" <bjorn.andersson@linaro.org>,
linux-soc@vger.kernel.org, "Andy Gross" <andy.gross@linaro.org>,
"David Brown" <david.brown@linaro.org>,
linux-kernel@vger.kernel.org,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral
Date: Wed, 15 Mar 2017 12:43:56 +0100 [thread overview]
Message-ID: <20170315114357.14446-1-j.neuschaefer@gmx.net> (raw)
If qcom_smem_get or qcom_smem_alloc return -EPROBE_DEFER, let the caller
the caller handle it, instead of treating it as an error.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v1:
- TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths:
smsm, smsm->entries, etc. are allocated (with devm_kzalloc), but not
freed when the function returns early. This should be addressed at
some point (in a separate patch).
---
drivers/soc/qcom/smsm.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c
index d0337b2a71c8..3918645e5708 100644
--- a/drivers/soc/qcom/smsm.c
+++ b/drivers/soc/qcom/smsm.c
@@ -439,7 +439,9 @@ static int smsm_get_size_info(struct qcom_smsm *smsm)
} *info;
info = qcom_smem_get(QCOM_SMEM_HOST_ANY, SMEM_SMSM_SIZE_INFO, &size);
- if (PTR_ERR(info) == -ENOENT || size != sizeof(*info)) {
+ if (PTR_ERR(info) == -EPROBE_DEFER) {
+ return PTR_ERR(info);
+ } else if (PTR_ERR(info) == -ENOENT || size != sizeof(*info)) {
dev_warn(smsm->dev, "no smsm size info, using defaults\n");
smsm->num_entries = SMSM_DEFAULT_NUM_ENTRIES;
smsm->num_hosts = SMSM_DEFAULT_NUM_HOSTS;
@@ -515,7 +517,9 @@ static int qcom_smsm_probe(struct platform_device *pdev)
/* Acquire the main SMSM state vector */
ret = qcom_smem_alloc(QCOM_SMEM_HOST_ANY, SMEM_SMSM_SHARED_STATE,
smsm->num_entries * sizeof(u32));
- if (ret < 0 && ret != -EEXIST) {
+ if (ret == -EPROBE_DEFER) {
+ return ret;
+ } else if (ret < 0 && ret != -EEXIST) {
dev_err(&pdev->dev, "unable to allocate shared state entry\n");
return ret;
}
--
2.11.0
next reply other threads:[~2017-03-15 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 11:43 Jonathan Neuschäfer [this message]
2017-03-15 11:43 ` [PATCH 2/2] soc: qcom: smsm: Avoid the use of an uninitialized value Jonathan Neuschäfer
2017-03-17 14:01 ` [PATCH 1/2] soc: qcom: smsm: Handle probe deferral Jonathan Neuschäfer
2017-03-28 6:18 ` Bjorn Andersson
2017-04-04 2:38 ` Jonathan Neuschäfer
2017-04-05 3:47 ` Bjorn Andersson
2017-04-05 12:10 ` [PATCH v2] soc: qcom: smsm: Improve error handling, quiesce " Jonathan Neuschäfer
2017-04-05 17:01 ` Bjorn Andersson
2017-05-31 14:00 ` Jonathan Neuschäfer
2017-06-01 6:34 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315114357.14446-1-j.neuschaefer@gmx.net \
--to=j.neuschaefer@gmx.net \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).