From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 3/6] drm/msm: Improve the zap shader Date: Mon, 17 Apr 2017 12:58:15 -0700 Message-ID: <20170417195815.GC12022@Bjorns-MacBook-Pro-2.local> References: <1492031718-28477-1-git-send-email-jcrouse@codeaurora.org> <1492031718-28477-4-git-send-email-jcrouse@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:34239 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbdDQT6S (ORCPT ); Mon, 17 Apr 2017 15:58:18 -0400 Received: by mail-pf0-f171.google.com with SMTP id c198so70175309pfc.1 for ; Mon, 17 Apr 2017 12:58:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1492031718-28477-4-git-send-email-jcrouse@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jordan Crouse Cc: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org On Wed 12 Apr 14:15 PDT 2017, Jordan Crouse wrote: > Simply the code use snprintf correctly and make sure that we memset > the rest of the segment if the memory size in the ELF file is larger > than the file size. > > Signed-off-by: Jordan Crouse Please squash this with the prior commits. > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 70 +++++++++++++++++------------------ > 1 file changed, 35 insertions(+), 35 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c [..] > @@ -151,9 +150,9 @@ static int _pil_tz_load_image(struct platform_device *pdev) > fw_size = (size_t) (fw_max_addr - fw_min_addr); > > /* Verify the MDT header */ > - ret = qcom_scm_pas_init_image(pas_id, mdt->data, mdt->size); > + ret = qcom_scm_pas_init_image(13, mdt->data, mdt->size); Please turn 13 into a define. > if (ret) { > - dev_err(&pdev->dev, "Invalid firmware metadata\n"); > + DRM_DEV_ERROR(&pdev->dev, "Invalid firmware metadata\n"); > goto out; > } > Regards, Bjorn