From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] drm/msm: gpu: Enable zap shader for A5XX
Date: Tue, 16 May 2017 12:40:54 -0700 [thread overview]
Message-ID: <20170516194054.GB12920@tuxbook> (raw)
In-Reply-To: <1494957638-14325-1-git-send-email-jcrouse@codeaurora.org>
On Tue 16 May 11:00 PDT 2017, Jordan Crouse wrote:
> diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
[..]
> +#ifdef CONFIG_QCOM_MDT_LOADER
Use
#if IS_ENABLED(CONFIG_QCOM_MDT_LOADER)
But this will be true even if the mdt-loader is compiled as a module and
the adreno driver builtin, which would cause a link error.
So in addition you need to add the following to your Kconfig:
depends on QCOM_MDT_LOADER || QCOM_MDT_LOADER=n
This will make sure that if the mdt-loader is "m" this driver has to be
"m" (i.e. it will still link), but if the mdt-loader is "n" we can still
compile this driver, but the #if in the code will be false.
Apart from this:
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
prev parent reply other threads:[~2017-05-16 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 18:00 [PATCH v4] drm/msm: gpu: Enable zap shader for A5XX Jordan Crouse
2017-05-16 19:40 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516194054.GB12920@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).