From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v4] drm/msm: gpu: Enable zap shader for A5XX Date: Tue, 16 May 2017 12:40:54 -0700 Message-ID: <20170516194054.GB12920@tuxbook> References: <1494957638-14325-1-git-send-email-jcrouse@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:35121 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdEPTk5 (ORCPT ); Tue, 16 May 2017 15:40:57 -0400 Received: by mail-pf0-f169.google.com with SMTP id n23so80387524pfb.2 for ; Tue, 16 May 2017 12:40:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1494957638-14325-1-git-send-email-jcrouse@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jordan Crouse Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org On Tue 16 May 11:00 PDT 2017, Jordan Crouse wrote: > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c [..] > +#ifdef CONFIG_QCOM_MDT_LOADER Use #if IS_ENABLED(CONFIG_QCOM_MDT_LOADER) But this will be true even if the mdt-loader is compiled as a module and the adreno driver builtin, which would cause a link error. So in addition you need to add the following to your Kconfig: depends on QCOM_MDT_LOADER || QCOM_MDT_LOADER=n This will make sure that if the mdt-loader is "m" this driver has to be "m" (i.e. it will still link), but if the mdt-loader is "n" we can still compile this driver, but the #if in the code will be false. Apart from this: Acked-by: Bjorn Andersson Regards, Bjorn