From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: "Dwivedi, Avaneesh Kumar (avani)" <akdwived@codeaurora.org>
Cc: sboyd@codeaurora.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [RESEND: PATCH v4 1/4] firmware: scm: Add new SCM call for switching memory ownership
Date: Fri, 26 May 2017 12:19:51 -0700 [thread overview]
Message-ID: <20170526191951.GK12920@tuxbook> (raw)
In-Reply-To: <2206f468-769b-c743-29e9-6fe0a13086d2@codeaurora.org>
On Fri 26 May 06:01 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote:
> On 5/26/2017 11:33 AM, Bjorn Andersson wrote:
> > On Tue 16 May 11:01 PDT 2017, Avaneesh Kumar Dwivedi wrote:
[..]
> > > diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
[..]
> > > +#define QCOM_SCM_VMID_HLOS 0x3
> > > +#define QCOM_SCM_VMID_MSS_MSA 0xF
> > > +#define QCOM_SCM_PERM_READ 0x4
> > > +#define QCOM_SCM_PERM_WRITE 0x2
> > > +#define QCOM_SCM_PERM_EXEC 0x1
> > > +#define QCOM_SCM_PERM_RW (QCOM_SCM_PERM_READ | QCOM_SCM_PERM_WRITE)
> > Add QCOM_SCM_PERM_RWX, as this looks fairly common as well.
> You mean change name as QCOM_SCM_PERM_RWX instead of QCOM_SCM_PERM_RW ? OK.
Provide both RW and RWX, as already in the first client of this API
you're using both.
Thanks,
Bjorn
next prev parent reply other threads:[~2017-05-26 19:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 18:01 [RESEND: PATCH v4 0/4] Add memory ownership switch support and enable mss rproc on msm8996 Avaneesh Kumar Dwivedi
2017-05-16 18:01 ` [RESEND: PATCH v4 1/4] firmware: scm: Add new SCM call for switching memory ownership Avaneesh Kumar Dwivedi
2017-05-26 6:03 ` Bjorn Andersson
2017-05-26 13:01 ` Dwivedi, Avaneesh Kumar (avani)
2017-05-26 19:19 ` Bjorn Andersson [this message]
2017-05-16 18:02 ` [RESEND: PATCH v4 2/4] remoteproc: qcom: refactor mss fw image loading sequence Avaneesh Kumar Dwivedi
2017-05-20 2:55 ` Sricharan R
2017-05-22 9:33 ` Dwivedi, Avaneesh Kumar (avani)
2017-05-22 10:37 ` Sricharan R
2017-05-22 13:26 ` Dwivedi, Avaneesh Kumar (avani)
2017-05-25 19:03 ` Bjorn Andersson
2017-05-26 5:00 ` Sricharan R
2017-05-25 19:13 ` Bjorn Andersson
2017-05-26 13:02 ` Dwivedi, Avaneesh Kumar (avani)
2017-05-16 18:02 ` [RESEND: PATCH v4 3/4] remoteproc: qcom: Make secure world call for mem ownership switch Avaneesh Kumar Dwivedi
2017-05-26 2:16 ` Bjorn Andersson
2017-05-26 13:19 ` Dwivedi, Avaneesh Kumar (avani)
2017-05-26 19:17 ` Bjorn Andersson
2017-05-16 18:02 ` [RESEND: PATCH v4 4/4] remoteproc: qcom: Add support for mss boot on msm8996 Avaneesh Kumar Dwivedi
2017-05-26 6:09 ` Bjorn Andersson
2017-05-26 13:20 ` Dwivedi, Avaneesh Kumar (avani)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526191951.GK12920@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=agross@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).