From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RESEND: PATCH v4 1/4] firmware: scm: Add new SCM call for switching memory ownership Date: Fri, 26 May 2017 12:19:51 -0700 Message-ID: <20170526191951.GK12920@tuxbook> References: <1494957722-13264-1-git-send-email-akdwived@codeaurora.org> <1494957722-13264-2-git-send-email-akdwived@codeaurora.org> <20170526060341.GG12920@tuxbook> <2206f468-769b-c743-29e9-6fe0a13086d2@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:33129 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S944790AbdEZTTV (ORCPT ); Fri, 26 May 2017 15:19:21 -0400 Received: by mail-pf0-f171.google.com with SMTP id e193so19636484pfh.0 for ; Fri, 26 May 2017 12:19:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <2206f468-769b-c743-29e9-6fe0a13086d2@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Dwivedi, Avaneesh Kumar (avani)" Cc: sboyd@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org On Fri 26 May 06:01 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > On 5/26/2017 11:33 AM, Bjorn Andersson wrote: > > On Tue 16 May 11:01 PDT 2017, Avaneesh Kumar Dwivedi wrote: [..] > > > diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h [..] > > > +#define QCOM_SCM_VMID_HLOS 0x3 > > > +#define QCOM_SCM_VMID_MSS_MSA 0xF > > > +#define QCOM_SCM_PERM_READ 0x4 > > > +#define QCOM_SCM_PERM_WRITE 0x2 > > > +#define QCOM_SCM_PERM_EXEC 0x1 > > > +#define QCOM_SCM_PERM_RW (QCOM_SCM_PERM_READ | QCOM_SCM_PERM_WRITE) > > Add QCOM_SCM_PERM_RWX, as this looks fairly common as well. > You mean change name as QCOM_SCM_PERM_RWX instead of QCOM_SCM_PERM_RW ? OK. Provide both RW and RWX, as already in the first client of this API you're using both. Thanks, Bjorn