From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V1 05/15] spmi: pmic-arb: cleanup unrequested irqs Date: Tue, 30 May 2017 18:57:53 -0700 Message-ID: <20170531015753.GW20170@codeaurora.org> References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-6-git-send-email-kgunda@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:45486 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdEaB5z (ORCPT ); Tue, 30 May 2017 21:57:55 -0400 Content-Disposition: inline In-Reply-To: <1496147943-25822-6-git-send-email-kgunda@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Kiran Gunda Cc: Abhijeet Dharmapurikar , Subbaraman Narayanamurthy , Christophe JAILLET , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com On 05/30, Kiran Gunda wrote: > From: Abhijeet Dharmapurikar > > We see a unmapped irqs trigger right around bootup. This could > likely be because the bootloader exited leaving the interrupts > in an unknown or unhandled state. Ack and mask the interrupt > if one is found. A request_irq later will unmask it and also > setup proper mapping structures. Do we have systems where this is causing an interrupt storm due to a level high interrupt or something? Just plain acking and masking irqs at boot if we don't have an irq descriptor created yet doesn't sound like a good idea, because we'll lose all interrupts that happen before this driver probes? > > Also the current driver ensures that no read/write transaction > is in progress while it makes changes to the interrupt regions. > This is not necessary because read/writes over spmi and arbiter > interrupt control are independent operations. Hence, remove the > synchronized accesses to interrupt region. That's another patch for this paragraph. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project