From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
Rajendra Nayak <rnayak@codeaurora.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] thermal: qcom: tsens: fix crash due to incorrect __init
Date: Fri, 30 Jun 2017 14:22:24 -0700 [thread overview]
Message-ID: <20170630212224.GF18666@tuxbook> (raw)
In-Reply-To: <20170630204023.31712-1-robdclark@gmail.com>
On Fri 30 Jun 13:40 PDT 2017, Rob Clark wrote:
> init_common() is called from probe, which can happen after the __init
> section is already unloaded in the case of -EPROBE_DEFER. Causing a
> later probe to attempt to branch to hyperspace.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/thermal/qcom/tsens-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index b1449ad..22ad37c 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -123,7 +123,7 @@ static const struct regmap_config tsens_config = {
> .reg_stride = 4,
> };
>
> -int __init init_common(struct tsens_device *tmdev)
> +int init_common(struct tsens_device *tmdev)
> {
> void __iomem *base;
>
> --
> 2.9.4
>
next prev parent reply other threads:[~2017-06-30 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 20:40 [PATCH] thermal: qcom: tsens: fix crash due to incorrect __init Rob Clark
2017-06-30 21:22 ` Bjorn Andersson [this message]
2017-07-14 3:46 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630212224.GF18666@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).