From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] spmi: pmic-arb: fix nullptr deref on v1 hardware Date: Mon, 10 Jul 2017 18:21:37 -0700 Message-ID: <20170711012137.GM22780@codeaurora.org> References: <20170708184644.2158-1-luca@z3ntu.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:46598 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdGKBVk (ORCPT ); Mon, 10 Jul 2017 21:21:40 -0400 Content-Disposition: inline In-Reply-To: <20170708184644.2158-1-luca@z3ntu.xyz> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Luca Weiss Cc: linux-arm-msm@vger.kernel.org, Roy Spliet On 07/08, Luca Weiss wrote: > [ 1.250120] Unable to handle kernel NULL pointer dereference at virtual address 00000940 > [ 1.255299] pgd = c0204000 > [ 1.263503] [00000940] *pgd=00000000 > [ 1.266009] Internal error: Oops: 5 [#1] PREEMPT SMP ARM > [ 1.269696] Modules linked in: > [ 1.274986] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.12.0-08608-g25b3421a06a9 #1 > [ 1.277863] Hardware name: Generic DT based system > [ 1.285404] task: ee8a0000 task.stack: ee89c000 > [ 1.290277] PC is at pmic_arb_ppid_to_apid_v1+0x14/0xf0 > [ 1.294698] LR is at qpnpint_irq_domain_dt_translate+0xa8/0x1bc > > [ 1.717902] [] (pmic_arb_ppid_to_apid_v1) from [] (qpnpint_irq_domain_dt_translate+0xa8/0x1bc) > [ 1.726066] [] (qpnpint_irq_domain_dt_translate) from [] (irq_create_fwspec_mapping+0x298/0x2f0) > [ 1.736305] [] (irq_create_fwspec_mapping) from [] (irq_create_of_mapping+0x4c/0x54) > > Fixes: 7f1d4e58dabb ("spmi: pmic-arb: optimize table lookups") > > Signed-off-by: Luca Weiss > Signed-off-by: Roy Spliet > --- Thanks. I already sent a patch for this one though: http://lkml.kernel.org/r/20170627021746.22445-1-sboyd@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project