From: Georgi Djakov <georgi.djakov@linaro.org>
To: sboyd@codeaurora.org
Cc: mturquette@baylibre.com, andy.gross@linaro.org,
architt@codeaurora.org, hverkuil@xs4all.nl,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
georgi.djakov@linaro.org
Subject: [PATCH v2] clk: qcom: clk-smd-rpm: Fix the reported rate of branches
Date: Thu, 13 Jul 2017 16:32:24 +0300 [thread overview]
Message-ID: <20170713133224.753-1-georgi.djakov@linaro.org> (raw)
In-Reply-To: <20170712231413.GP22780@codeaurora.org>
As there is no way to actually query the hardware for the current clock
rate, now racalc_rate() just returns the last rate that was previously
set. But if the rate was not set yet, we return the bogus rate of 1000Hz.
The branch clocks actually have the same rate as their parent (xo_board),
so just return this rate.
Reported-by: Archit Taneja <architt@codeaurora.org>
Fixes: 00f64b58874e ("clk: qcom: Add support for SMD-RPM Clocks")
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/clk/qcom/clk-smd-rpm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
index d990fe44aef3..b45782657ca9 100644
--- a/drivers/clk/qcom/clk-smd-rpm.c
+++ b/drivers/clk/qcom/clk-smd-rpm.c
@@ -364,6 +364,10 @@ static unsigned long clk_smd_rpm_recalc_rate(struct clk_hw *hw,
{
struct clk_smd_rpm *r = to_clk_smd_rpm(hw);
+ /* Return the parent rate for branches */
+ if (r->branch)
+ return parent_rate;
+
/*
* RPM handles rate rounding and we don't have a way to
* know what the rate will be, so just return whatever
next prev parent reply other threads:[~2017-07-13 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 12:34 [PATCH] clk: qcom: clk-smd-rpm: Fix the initial rate of branches Georgi Djakov
2017-07-06 9:53 ` Archit Taneja
2017-07-06 10:13 ` Hans Verkuil
2017-07-12 23:11 ` Stephen Boyd
2017-07-12 23:14 ` Stephen Boyd
2017-07-13 13:32 ` Georgi Djakov [this message]
2017-07-13 21:56 ` [PATCH v2] clk: qcom: clk-smd-rpm: Fix the reported " Stephen Boyd
2017-07-14 13:01 ` Georgi Djakov
2017-07-17 15:35 ` [PATCH v3] " Georgi Djakov
2017-07-18 1:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713133224.753-1-georgi.djakov@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).