From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Date: Tue, 18 Jul 2017 21:49:57 +0530 Message-ID: <20170718161956.GV3053@localhost> References: <1498789858-18583-1-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga14.intel.com ([192.55.52.115]:3763 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbdGRQRN (ORCPT ); Tue, 18 Jul 2017 12:17:13 -0400 Content-Disposition: inline In-Reply-To: <1498789858-18583-1-git-send-email-okaya@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Gross , David Brown , Dan Williams , linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 10:30:57PM -0400, Sinan Kaya wrote: > @@ -410,7 +410,40 @@ static int hidma_alloc_chan_resources(struct dma_chan *dmach) > return NULL; > > hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch, > - src, dest, len, flags); > + src, dest, len, flags, > + HIDMA_TRE_MEMCPY); > + > + /* Place descriptor in prepared list */ > + spin_lock_irqsave(&mchan->lock, irqflags); > + list_add_tail(&mdesc->node, &mchan->prepared); > + spin_unlock_irqrestore(&mchan->lock, irqflags); This change looks suspicious, cna you clarify the need to do this? -- ~Vinod