linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rob Clark <robdclark@gmail.com>,
	freedreno@lists.freedesktop.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] drm/msm/mdp5: Fix compilation warnings
Date: Wed, 19 Jul 2017 18:26:12 +0530	[thread overview]
Message-ID: <20170719125612.GG352@vireshk-i7> (raw)
In-Reply-To: <150046643091.30670.12161137449702421099@mail.alporthouse.com>

On 19-07-17, 13:13, Chris Wilson wrote:
> Quoting Viresh Kumar (2017-06-29 10:19:59)
> > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> > index 7d3741215387..0ee9bd0041cd 100644
> > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> > @@ -889,8 +889,8 @@ static int mdp5_plane_mode_set(struct drm_plane *plane,
> >         struct mdp5_hw_pipe *right_hwpipe;
> >         const struct mdp_format *format;
> >         uint32_t nplanes, config = 0;
> > -       struct phase_step step = { 0 };
> > -       struct pixel_ext pe = { 0 };
> > +       struct phase_step step = { { 0 } };
> > +       struct pixel_ext pe = { { 0 } };
> >         uint32_t hdecm = 0, vdecm = 0;
> >         uint32_t pix_format;
> >         unsigned int rotation;
> 
> Or just use {} to initialise to zero whatever the struct layout?

Maybe, as GNU C allows that but ANSI C doesn't.

-- 
viresh

      reply	other threads:[~2017-07-19 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29  9:19 [PATCH] drm/msm/mdp5: Fix compilation warnings Viresh Kumar
     [not found] ` <627f428ee808c68e28d9f97a88191fbbe3ed389f.1498727804.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-07-18  6:34   ` Viresh Kumar
2017-07-18  9:41     ` Rob Clark
2017-07-19 12:13 ` Chris Wilson
2017-07-19 12:56   ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719125612.GG352@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).