From: Stephen Boyd <sboyd@codeaurora.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: mturquette@baylibre.com, robdclark@gmail.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops
Date: Wed, 23 Aug 2017 15:55:43 -0700 [thread overview]
Message-ID: <20170823225543.GJ21656@codeaurora.org> (raw)
In-Reply-To: <20170818142250.27867-1-georgi.djakov@linaro.org>
On 08/18, Georgi Djakov wrote:
> The clock bimc_gpu_clk_src is incorrectly set to use the shared rcg2
> ops, which are for RCGs with child branches controlled by different
> CPUs.
>
> The result of the incorrect ops is that the GPU's PM runtime may leave
> this clock set at a very low rate. Fix this issue by using the correct
> rcg2 ops.
>
> Fixes: a2e8272f3f89 ("clk: qcom: Add MSM8916 gpu clocks")
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
This is the only user of clk_rcg2_shared_ops. I'm totally lost
why we added this in the first place.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-08-23 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 14:22 [PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops Georgi Djakov
2017-08-23 22:55 ` Stephen Boyd [this message]
2017-08-24 17:35 ` Georgi Djakov
2017-08-24 17:36 ` [PATCH] clk: qcom: Remove unused RCG ops Georgi Djakov
2017-11-02 6:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823225543.GJ21656@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).