From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2 3/5] soc: qcom: smem: Support global partition Date: Fri, 15 Sep 2017 11:33:34 -0700 Message-ID: <20170915183334.GQ2016@tuxbook> References: <1505424302-29147-1-git-send-email-clew@codeaurora.org> <1505424302-29147-4-git-send-email-clew@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f179.google.com ([209.85.192.179]:46711 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdIOSdl (ORCPT ); Fri, 15 Sep 2017 14:33:41 -0400 Received: by mail-pf0-f179.google.com with SMTP id e199so1863893pfh.3 for ; Fri, 15 Sep 2017 11:33:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1505424302-29147-4-git-send-email-clew@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Chris Lew Cc: andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote: [..] > +static struct smem_ptable *qcom_smem_get_ptable(struct qcom_smem *smem) > { > - struct smem_partition_header *header; > - struct smem_ptable_entry *entry; > struct smem_ptable *ptable; > - unsigned remote_host; > - u32 version, host0, host1; > - int i; > + u32 version; > > ptable = smem->regions[0].virt_base + smem->regions[0].size - SZ_4K; > if (memcmp(ptable->magic, SMEM_PTABLE_MAGIC, sizeof(ptable->magic))) > - return 0; > + return NULL; > > version = le32_to_cpu(ptable->version); > if (version != 1) { > dev_err(smem->dev, > "Unsupported partition header version %d\n", version); > + return ERR_PTR(-EINVAL); In the calling places NULL and -EINVAL are both treated as -EINVAL, so I think it's better to just return NULL here as well as check for !ptable in callers. Regards, Bjorn