From: David Miller <davem@davemloft.net>
To: bjorn.andersson@linaro.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, clew@codeaurora.org
Subject: Re: [RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2 packets
Date: Thu, 05 Oct 2017 18:05:39 -0700 (PDT) [thread overview]
Message-ID: <20171005.180539.381799694621402344.davem@davemloft.net> (raw)
In-Reply-To: <20171005035105.14677-8-bjorn.andersson@linaro.org>
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Wed, 4 Oct 2017 20:51:05 -0700
> +/**
> + * struct qrtr_hdr_v2 - (I|R)PCrouter packet header later versions
> + * @version: protocol version
> + * @type: packet type; one of QRTR_TYPE_*
> + * @flags: bitmask of QRTR_FLAGS_*
> + * @optlen: length of optional header data
> + * @size: length of packet, excluding this header and optlen
> + * @src_node_id: source node
> + * @src_port_id: source port
> + * @dst_node_id: destination node
> + * @dst_port_id: destination port
> + */
> +struct qrtr_hdr_v2 {
> + u8 version;
> + u8 type;
> + u8 flags;
> + u8 optlen;
> + __le32 size;
> + __le16 src_node_id;
> + __le16 src_port_id;
> + __le16 dst_node_id;
> + __le16 dst_port_id;
> +} __packed;
__packed should be only used when it is provably necessary, and it
should not be needed here.
prev parent reply other threads:[~2017-10-06 1:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 3:50 [RESEND PATCH 0/7] net: qrtr: Fixes and support receiving version 2 packets Bjorn Andersson
2017-10-05 3:50 ` [RESEND PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err Bjorn Andersson
2017-10-05 3:51 ` [RESEND PATCH 2/7] net: qrtr: Move constants to header file Bjorn Andersson
2017-10-05 3:51 ` [RESEND PATCH 3/7] net: qrtr: Add control packet definition to uapi Bjorn Andersson
2017-10-05 3:51 ` [RESEND PATCH 4/7] net: qrtr: Pass source and destination to enqueue functions Bjorn Andersson
2017-10-05 3:51 ` [RESEND PATCH 5/7] net: qrtr: Clean up control packet handling Bjorn Andersson
2017-10-05 3:51 ` [RESEND PATCH 6/7] net: qrtr: Use sk_buff->cb in receive path Bjorn Andersson
2017-10-05 3:51 ` [RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2 packets Bjorn Andersson
2017-10-06 1:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005.180539.381799694621402344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).