From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2] arm64: qcom: sbc: Name GPIO lines Date: Tue, 10 Oct 2017 22:54:05 -0700 Message-ID: <20171011055405.GI1165@minitux> References: <20171009092844.11451-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f52.google.com ([74.125.83.52]:43275 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbdJKFyJ (ORCPT ); Wed, 11 Oct 2017 01:54:09 -0400 Received: by mail-pg0-f52.google.com with SMTP id n4so456325pgn.0 for ; Tue, 10 Oct 2017 22:54:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20171009092844.11451-1-linus.walleij@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Andy Gross , David Brown , Stephen Boyd , linux-soc@vger.kernel.org On Mon 09 Oct 02:28 PDT 2017, Linus Walleij wrote: > This names the GPIO lines on the APQ8016 "SBC" also known > as the DragonBoard 410c, according to the schematic. This > is necessary for a conforming userspace looking across > all GPIO chips for the GPIO lines named "GPIO-A" thru > "GPIO-L". > > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Put the GPIO line names into the .dtsi file for the > SBC as requested. > - Put the GPIO line names into the hierarchical SoC > DTS structure as requested. > - Adjusted legend text to only cover used terminology. > - Insert proper comments telling which line on the LSEC > or HSEC a certain line is routed to. > > I don't have this hardware available, you can test it > easily by compiling tools/gpio/* and issue "lsgpio" to > see the GPIO line names in the console. > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 169 ++++++++++++++++++++++++++++++ > 1 file changed, 169 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi [..] > + "NC", /* GPIO 70 */ > + "NC", > + "NC", > + "NC", > + "NC", /* GPIO 74 */ Convenient to know where index 74 is ;P > + "NC", > + "NC", > + "NC", > + "NC", > + "NC", > + "BOOT_CONFIG_0", /* GPIO 80 */ Acked-by: Bjorn Andersson Regards, Bjorn