From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 2/4] ARM: dts: msm8974-FP2: Introduce gpio-keys nodes Date: Tue, 10 Oct 2017 23:05:11 -0700 Message-ID: <20171011060511.GK1165@minitux> References: <20170912084012.12725-1-luca@z3ntu.xyz> <20170912084012.12725-2-luca@z3ntu.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f45.google.com ([74.125.83.45]:57258 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdJKGFO (ORCPT ); Wed, 11 Oct 2017 02:05:14 -0400 Received: by mail-pg0-f45.google.com with SMTP id m18so469060pgd.13 for ; Tue, 10 Oct 2017 23:05:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170912084012.12725-2-luca@z3ntu.xyz> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Luca Weiss Cc: linux-arm-msm@vger.kernel.org On Tue 12 Sep 01:40 PDT 2017, Luca Weiss wrote: > This introduces the gpio-keys nodes for keys of the FP2 and the > associated pinctrl state. > > Signed-off-by: Luca Weiss > --- > arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 50 ++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > index 79a5aa8b856a..4434c45086b8 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > +++ b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts > @@ -1,6 +1,10 @@ > #include "qcom-msm8974.dtsi" > #include "qcom-pm8841.dtsi" > #include "qcom-pm8941.dtsi" > +#include > +#include > +#include > + > > / { > model = "Fairphone 2"; > @@ -19,4 +23,50 @@ > serial@f991e000 { > status = "ok"; > }; > + > + gpio-keys { As this isn't a device on the "soc bus" (i.e. it doesn't have a reg=<>) it should not be child of &soc. Please move it to /, i.e. right after "choosen". Regards, Bjorn