From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/5] ARM: dts: msm8974-FP2: Introduce gpio-keys nodes
Date: Wed, 11 Oct 2017 10:12:15 -0700 [thread overview]
Message-ID: <20171011171215.GS1165@minitux> (raw)
In-Reply-To: <20171011110229.24413-2-luca@z3ntu.xyz>
On Wed 11 Oct 04:02 PDT 2017, Luca Weiss wrote:
> This introduces the gpio-keys nodes for keys of the FP2 and the
> associated pinctrl state.
>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 50 ++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
> index 79a5aa8b856a..9332c6e9c535 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
> @@ -1,6 +1,10 @@
> #include "qcom-msm8974.dtsi"
> #include "qcom-pm8841.dtsi"
> #include "qcom-pm8941.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +
>
> / {
> model = "Fairphone 2";
> @@ -13,6 +17,38 @@
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + input-name = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gpio_keys_pin_a>;
> +
> + camera-snapshot {
> + label = "camera_snapshot";
> + gpios = <&pm8941_gpios 1 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_CAMERA>;
> + wakeup-source;
> + debounce-interval = <15>;
> + };
> +
> + volume-down {
> + label = "volume_down";
> + gpios = <&pm8941_gpios 2 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEDOWN>;
> + wakeup-source;
> + debounce-interval = <15>;
> + };
> +
> + volume-up {
> + label = "volume_up";
> + gpios = <&pm8941_gpios 5 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + wakeup-source;
> + debounce-interval = <15>;
> + };
> + };
> };
>
> &soc {
> @@ -20,3 +56,17 @@
> status = "ok";
> };
> };
> +
> +&spmi_bus {
> + pm8941@0 {
> + gpios@c000 {
> + gpio_keys_pin_a: gpio-keys-active {
> + pins = "gpio1", "gpio2", "gpio5";
> + function = "normal";
> +
> + bias-pull-up;
> + power-source = <PM8941_GPIO_S3>;
> + };
> + };
> + };
> +};
> --
> 2.14.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-11 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:02 [PATCH v2 1/5] ARM: dts: qcom: Add initial DTS file for Fairphone 2 phone Luca Weiss
2017-10-11 11:02 ` [PATCH v2 2/5] ARM: dts: msm8974-FP2: Introduce gpio-keys nodes Luca Weiss
2017-10-11 17:12 ` Bjorn Andersson [this message]
2017-10-11 11:02 ` [PATCH v2 3/5] ARM: dts: msm8974-FP2: Add regulator nodes for FP2 Luca Weiss
2017-10-11 17:20 ` Bjorn Andersson
2017-10-11 11:02 ` [PATCH v2 4/5] ARM: dts: msm8974-FP2: Add sdhci1 node Luca Weiss
2017-10-11 17:20 ` Bjorn Andersson
2017-10-11 11:02 ` [PATCH v2 5/5] ARM: dts: msm8974-FP2: Add USB node Luca Weiss
2017-10-11 17:21 ` Bjorn Andersson
2017-10-11 17:11 ` [PATCH v2 1/5] ARM: dts: qcom: Add initial DTS file for Fairphone 2 phone Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2017-10-11 17:17 [PATCH v2 2/5] ARM: dts: msm8974-FP2: Introduce gpio-keys nodes Rishi Bhattacharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011171215.GS1165@minitux \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).