From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v3 1/5] soc: qcom: smem: Use le32_to_cpu for comparison Date: Wed, 11 Oct 2017 20:54:57 -0700 Message-ID: <20171012035457.GX1165@minitux> References: <1507757350-10508-1-git-send-email-clew@quicinc.com> <1507757350-10508-2-git-send-email-clew@quicinc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f174.google.com ([209.85.192.174]:45760 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbdJLDzA (ORCPT ); Wed, 11 Oct 2017 23:55:00 -0400 Received: by mail-pf0-f174.google.com with SMTP id d28so3170838pfe.2 for ; Wed, 11 Oct 2017 20:55:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1507757350-10508-2-git-send-email-clew@quicinc.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Chris Lew Cc: andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, clew@codeaurora.org On Wed 11 Oct 14:29 PDT 2017, Chris Lew wrote: > From: Chris Lew > > Endianness can vary in the system, add le32_to_cpu when comparing > partition sizes from smem. > Acked-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Chris Lew > --- > > Changes since v1: > - New change > > Changes since v2: > - Reduce subject to 50 chars and wrap summary to 72 chars > > drivers/soc/qcom/smem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index c28275be0038..db04c45d4132 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem, > return -EINVAL; > } > > - if (header->size != entry->size) { > + if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) { > dev_err(smem->dev, > "Partition %d has invalid size\n", i); > return -EINVAL; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >