From: fenglinw@codeaurora.org
To: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: collinsd@codeaurora.org, aghayal@codeaurora.org,
wruan@codeaurora.org, subbaram@codeaurora.org,
kgunda@codeaurora.org, Fenglin Wu <fenglinw@codeaurora.org>
Subject: [PATCH V1 0/2] *** Update is_enabled flag to be consistent ***
Date: Fri, 13 Oct 2017 14:15:02 +0800 [thread overview]
Message-ID: <20171013061550.996-1-fenglinw@codeaurora.org> (raw)
From: Fenglin Wu <fenglinw@codeaurora.org>
Currently, is_enabled flag is always set to true in pmic_gpio_populate()
regardless of the hardware real time status. This is not correct and it
gives the wrong information for the GPIOs which are disabled initially
in hardware. Add two patches to fix this: One is set the is_enabled flag
via reading the REG_EN_CTL register then its value can reflect the corrent
initial hardware enable state; Another is set is_enable flag in
pmic_gpio_set_mux() so that any disabled GPIO could be enabled right after
setting pinmux.
Fenglin Wu (2):
pinctrl: qcom: spmi-gpio: Read REG_EN_CTL to get initial enable state
pinctrl: qcom: spmi-gpio: Set is_enabled flag in set_mux()
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next reply other threads:[~2017-10-13 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 6:15 fenglinw [this message]
2017-10-13 6:15 ` [PATCH V1 1/2] pinctrl: qcom: spmi-gpio: Read REG_EN_CTL to get initial enable state fenglinw
2017-10-16 22:19 ` Bjorn Andersson
2017-10-13 6:15 ` [PATCH V1 2/2] pinctrl: qcom: spmi-gpio: Set is_enabled flag in set_mux() fenglinw
2017-10-16 22:29 ` Bjorn Andersson
2017-10-17 4:36 ` Fenglin Wu
2017-10-20 9:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013061550.996-1-fenglinw@codeaurora.org \
--to=fenglinw@codeaurora.org \
--cc=aghayal@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=wruan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).