From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Newton Subject: [PATCH] mdp5: Return error values from mdp5_cfg_init Date: Thu, 30 Nov 2017 21:04:16 +0000 Message-ID: <20171130210416.8229-1-will.newton@gmail.com> Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:45161 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbdK3VEo (ORCPT ); Thu, 30 Nov 2017 16:04:44 -0500 Received: by mail-wm0-f65.google.com with SMTP id 9so81054wme.4 for ; Thu, 30 Nov 2017 13:04:43 -0800 (PST) Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rob Clark Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Will Newton The return value of this function is a pointer checked with IS_ERR, so we should be returning an error pointer rather than NULL when the init fails. Signed-off-by: Will Newton --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c index 824067d2d427..42f0ecb0cf35 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c @@ -635,7 +635,7 @@ struct mdp5_cfg_handler *mdp5_cfg_init(struct mdp5_kms *mdp5_kms, if (cfg_handler) mdp5_cfg_destroy(cfg_handler); - return NULL; + return ERR_PTR(ret); } static struct mdp5_cfg_platform *mdp5_get_config(struct platform_device *dev) -- 2.14.3