From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: PM8916 RPM regulator supply names too long Date: Tue, 12 Dec 2017 16:15:01 -0800 Message-ID: <20171213001501.GH4803@minitux> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f43.google.com ([74.125.83.43]:45218 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbdLMAPE (ORCPT ); Tue, 12 Dec 2017 19:15:04 -0500 Received: by mail-pg0-f43.google.com with SMTP id m25so469489pgv.12 for ; Tue, 12 Dec 2017 16:15:04 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Will Newton Cc: linux-arm-msm@vger.kernel.org On Tue 12 Dec 07:11 PST 2017, Will Newton wrote: > Hi, > > I noticed that in drivers/regulator/qcom_smd-regulator.c there are > supply names such as: > > "vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18" > > This gets looked up in the DT (with the string "-supply" appended) but > this will always fail due to the name exceeding the 32 character > maximum of a DT attribute and getting truncated. That's not good, I guess we have to game the system and rename this "vdd_l8-l18" or something like that. > Is this a known issue? I'm curious as to why MSM8916 users are not > finding this a problem in practice. I haven't heard anyone complain about this before. The reason why we haven't this this issue is because at least on db410c the supply is vph_pwr which is an always on, fixed, 3.7V line, which we don't describe in DT (but probably should for completeness). Regards, Bjorn