From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH v2] drm/msm: Fix NULL deref in adreno_load_gpu Date: Tue, 2 Jan 2018 11:32:19 -0700 Message-ID: <20180102183219.GA26197@jcrouse-lnx.qualcomm.com> References: <20171214054150.20943-1-architt@codeaurora.org> <20171222101113.31615-1-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171222101113.31615-1-architt@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org T24gRnJpLCBEZWMgMjIsIDIwMTcgYXQgMDM6NDE6MTNQTSArMDUzMCwgQXJjaGl0IFRhbmVqYSB3 cm90ZToKPiBUaGUgbXNtL2ttcyBkcml2ZXIgc2hvdWxkIHdvcmsgZXZlbiBpZiB0aGVyZSBpcyBu byBHUFUgZGV2aWNlIHNwZWNpZmllZAo+IGluIERULiBDdXJyZW50bHksIHdlIGdldCBhIE5VTEwg ZGVyZWZlcmVuY2UgY3Jhc2ggaW4gYWRyZW5vX2xvYWRfZ3B1Cj4gc2luY2UgdGhlIGRyaXZlciBh c3N1bWVzIHRoYXQgcHJpdi0+Z3B1X3BkZXYgaXMgbm9uLU5VTEwuCj4gCj4gUGVyZm9ybSBhbiBh ZGRpdGlvbmFsIGNoZWNrIG9uIHByaXYtPmdwdV9wZGV2IGJlZm9yZSB0cnlpbmcgdG8gcmV0cmll dmUKPiB0aGUgbXNtX2dwdSBwb2ludGVyIGZyb20gaXQuCj4gCj4gdjI6IEluY29ycG9yYXRlIEpv cmRhbidzIGNvbW1lbnRzOgo+IC0gU2ltcGxpZnkgdGhlIGNoZWNrIHRvIHNoYXJlIHRoZSBzYW1l IGVycm9yIG1lc3NhZ2UuCj4gLSBVc2UgZGV2X2Vycl9vbmNlKCkgdG8gYXZvaWQgYW4gZXJyb3Ig bWVzc2FnZSBldmVyeSB0aW1lIHdlIG9wZW4gdGhlCj4gICBkcm0gZGV2aWNlIGZkLgo+IAo+IEZp eGVzOiBlZWM4NzRjZTVmZjEgKGRybS9tc20vYWRyZW5vOiBsb2FkIGdwdSBhdCBwcm9iZS9iaW5k IHRpbWUpCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVy b3JhLm9yZz4KCkFja2VkLWJ5OiBKb3JkYW4gQ3JvdXNlIDxqY3JvdXNlQGNvZGVhdXJvcmEub3Jn PgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2RldmljZS5jIHwg NyArKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19k ZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19kZXZpY2UuYwo+IGlu ZGV4IDA1MDIyZWEyYTAwNy4uYmZiM2Q2ODlmNDdkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9tc20vYWRyZW5vL2FkcmVub19kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9t c20vYWRyZW5vL2FkcmVub19kZXZpY2UuYwo+IEBAIC0xMjUsMTEgKzEyNSwxNCBAQCBzdHJ1Y3Qg bXNtX2dwdSAqYWRyZW5vX2xvYWRfZ3B1KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIHsKPiAg CXN0cnVjdCBtc21fZHJtX3ByaXZhdGUgKnByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiA9IHByaXYtPmdwdV9wZGV2Owo+IC0Jc3RydWN0IG1z bV9ncHUgKmdwdSA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHByaXYtPmdwdV9wZGV2KTsKPiArCXN0 cnVjdCBtc21fZ3B1ICpncHUgPSBOVUxMOwo+ICAJaW50IHJldDsKPiAgCj4gKwlpZiAocGRldikK PiArCQlncHUgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiArCj4gIAlpZiAoIWdwdSkg ewo+IC0JCWRldl9lcnIoZGV2LT5kZXYsICJubyBhZHJlbm8gZGV2aWNlXG4iKTsKPiArCQlkZXZf ZXJyX29uY2UoZGV2LT5kZXYsICJubyBHUFUgZGV2aWNlIHdhcyBmb3VuZFxuIik7Cj4gIAkJcmV0 dXJuIE5VTEw7Cj4gIAl9CgotLSAKVGhlIFF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMu IGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29s bGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=