From: Lina Iyer <ilina@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: tglx@linutronix.de, jason@lakedaemon.net,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
sboyd@codeaurora.org, rnayak@codeaurora.org,
asathyak@codeaurora.org
Subject: Re: [PATCH RFC 4/4] drivers: irqchip: qcom: add pin information for SDM845
Date: Thu, 25 Jan 2018 18:14:36 +0000 [thread overview]
Message-ID: <20180125181436.GB12603@codeaurora.org> (raw)
In-Reply-To: <2c96f5ec-3e7c-ca04-f265-c4fdc8475db2@arm.com>
On Wed, Jan 24 2018 at 14:20 +0000, Marc Zyngier wrote:
>On 23/01/18 17:56, Lina Iyer wrote:
>> From: Archana Sathyakumar <asathyak@codeaurora.org>
>>
>> +#include "qcom-pdc.h"
>> +
>> +const struct pdc_pin sdm845_data[] = {
>> + {0, 512}, /* rpmh_wake */
>> + {1, 513}, /* ee0_apps_hlos_spmi_periph_irq */
>> + {2, 514}, /* ee1_apps_trustzone_spmi_periph_irq */
>> + {3, 515}, /* secure_wdog_expired */
>> + {4, 516}, /* secure_wdog_bark_irq */
>> + {5, 517}, /* aop_wdog_expired_irq */
>> + {6, 518}, /* qmp_usb3_lfps_rxterm_irq */
>
>[...]
>
>Nice try, but no. This is DT material. Please use the pin number in your
>DT, which the driver uses as a hwirq. When it comes to mapping it to the
>corresponding GIC SPI, use a per-soc helper that comes from DT too (you
>seem to only have two ranges here, so that's pretty easy to do).
>
Thanks Marc. I will look into this approach.
-- Lina
next prev parent reply other threads:[~2018-01-25 18:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:56 [PATCH RFC 0/4] irqchip: qcom: add support for PDC interrupt controller Lina Iyer
2018-01-23 17:56 ` [PATCH RFC 1/4] drivers: irqchip: pdc: " Lina Iyer
2018-01-24 14:20 ` Marc Zyngier
2018-01-25 18:52 ` Lina Iyer
2018-01-30 17:56 ` Lina Iyer
2018-01-30 18:11 ` Marc Zyngier
2018-01-31 16:24 ` Lina Iyer
2018-01-31 16:46 ` Marc Zyngier
2018-02-01 16:49 ` Lina Iyer
2018-01-23 17:56 ` [PATCH RFC 2/4] dt-bindings/interrupt-controller: pdc: descibe PDC device binding Lina Iyer
2018-01-23 18:09 ` Sudeep Holla
2018-01-23 18:46 ` Lina Iyer
2018-01-24 14:24 ` Marc Zyngier
2018-01-30 15:20 ` Rob Herring
2018-01-23 17:56 ` [PATCH RFC 3/4] drivers: irqchip: pdc: log PDC info in FTRACE Lina Iyer
2018-01-23 18:13 ` Steven Rostedt
2018-01-25 15:45 ` Lina Iyer
2018-01-23 17:56 ` [PATCH RFC 4/4] drivers: irqchip: qcom: add pin information for SDM845 Lina Iyer
2018-01-24 14:20 ` Marc Zyngier
2018-01-25 18:14 ` Lina Iyer [this message]
2018-01-23 18:15 ` [PATCH RFC 0/4] irqchip: qcom: add support for PDC interrupt controller Sudeep Holla
2018-01-23 18:44 ` Lina Iyer
2018-01-24 10:10 ` Sudeep Holla
2018-01-24 17:43 ` Lina Iyer
2018-01-24 17:54 ` Sudeep Holla
2018-01-25 15:54 ` Lina Iyer
2018-01-25 16:39 ` Sudeep Holla
2018-01-25 18:13 ` Lina Iyer
2018-01-25 18:43 ` Sudeep Holla
2018-01-25 20:05 ` Lina Iyer
2018-01-26 11:39 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125181436.GB12603@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=asathyak@codeaurora.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rnayak@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).