From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH RFC 4/4] drivers: irqchip: qcom: add pin information for SDM845 Date: Thu, 25 Jan 2018 18:14:36 +0000 Message-ID: <20180125181436.GB12603@codeaurora.org> References: <20180123175656.11942-1-ilina@codeaurora.org> <20180123175656.11942-5-ilina@codeaurora.org> <2c96f5ec-3e7c-ca04-f265-c4fdc8475db2@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:48298 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbeAYSOh (ORCPT ); Thu, 25 Jan 2018 13:14:37 -0500 Content-Disposition: inline In-Reply-To: <2c96f5ec-3e7c-ca04-f265-c4fdc8475db2@arm.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Marc Zyngier Cc: tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, sboyd@codeaurora.org, rnayak@codeaurora.org, asathyak@codeaurora.org On Wed, Jan 24 2018 at 14:20 +0000, Marc Zyngier wrote: >On 23/01/18 17:56, Lina Iyer wrote: >> From: Archana Sathyakumar >> >> +#include "qcom-pdc.h" >> + >> +const struct pdc_pin sdm845_data[] = { >> + {0, 512}, /* rpmh_wake */ >> + {1, 513}, /* ee0_apps_hlos_spmi_periph_irq */ >> + {2, 514}, /* ee1_apps_trustzone_spmi_periph_irq */ >> + {3, 515}, /* secure_wdog_expired */ >> + {4, 516}, /* secure_wdog_bark_irq */ >> + {5, 517}, /* aop_wdog_expired_irq */ >> + {6, 518}, /* qmp_usb3_lfps_rxterm_irq */ > >[...] > >Nice try, but no. This is DT material. Please use the pin number in your >DT, which the driver uses as a hwirq. When it comes to mapping it to the >corresponding GIC SPI, use a per-soc helper that comes from DT too (you >seem to only have two ranges here, so that's pretty easy to do). > Thanks Marc. I will look into this approach. -- Lina