From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH RFC 1/4] drivers: irqchip: pdc: add support for PDC interrupt controller Date: Thu, 1 Feb 2018 16:49:56 +0000 Message-ID: <20180201164956.GB13231@codeaurora.org> References: <20180123175656.11942-1-ilina@codeaurora.org> <20180123175656.11942-2-ilina@codeaurora.org> <9dd8307c-4906-4707-d4d7-2ef0fc8307b6@arm.com> <20180130175654.GC20815@codeaurora.org> <619608bb-a9c5-27a1-2383-5f6b2f455499@arm.com> <20180131162432.GA13231@codeaurora.org> <83cfda67-511f-aa83-8eff-214c08de25e4@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <83cfda67-511f-aa83-8eff-214c08de25e4@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Marc Zyngier Cc: tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, sboyd@codeaurora.org, rnayak@codeaurora.org, asathyak@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org On Wed, Jan 31 2018 at 16:46 +0000, Marc Zyngier wrote: >On 31/01/18 16:24, Lina Iyer wrote: >> On Tue, Jan 30 2018 at 18:11 +0000, Marc Zyngier wrote: >>> On 30/01/18 17:56, Lina Iyer wrote: >>>> On Wed, Jan 24 2018 at 14:20 +0000, Marc Zyngier wrote: >>>>> On 23/01/18 17:56, Lina Iyer wrote: >>>>>> From : Archana Sathyakumar >>>>>> >>>>>> The Power Domain Controller (PDC) hardware block on Qualcomm SoCs houses >>>>>> an interrupt controller along with other domain control functions to >>>>>> handle interrupt related functions like handle falling edge or active >>>>>> low which are not detected at the GIC and handle wakeup interrupts. >>>>>> >>>>>> The interrupt controller is on an always-on domain for the purpose of >>>>>> waking up the processor, but only a subset of the processor's interrupts >>>>>> are routed through the PDC to the GIC. The PDC powers on the processor's >>>>>> domain, bringing the domain out of low power mode and replays the >>>>>> pending interrupts so the GIC may wake up the processor. >>>>>> >>>>>> Signed-off-by: Archana Sathyakumar >>>>>> Signed-off-by: Lina Iyer >>>>>> [Lina: Split out DT bindings target data and initialization changes] >>>>>> --- >>>> >> We looked at tegra's implementation and it appears similar, thought they >> don't seemt to have the same complexity. > >Exactly. They are pretty similar. Hence my suggestion to adopt the same >approach, which you don't seem to agree with. > I am reworking the driver based on what you have suggested in this thread. Will submit a patchset for review in the next couple of days. Once again, thank you for your time Marc. -- Lina