From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH v4 2/2] dt-bindings/interrupt-controller: pdc: descibe PDC device binding Date: Wed, 7 Feb 2018 16:50:05 +0000 Message-ID: <20180207165005.GB16153@codeaurora.org> References: <20180207154958.13421-1-ilina@codeaurora.org> <20180207154958.13421-3-ilina@codeaurora.org> <20180207164324.GP9465@builder> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <20180207164324.GP9465@builder> Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org, asathyak@codeaurora.org, devicetree@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Wed, Feb 07 2018 at 16:43 +0000, Bjorn Andersson wrote: >On Wed 07 Feb 07:49 PST 2018, Lina Iyer wrote: >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt >[..] >> +Example: >[..] >> + wake-device { >> + [...] >> + interrupt-controller = <&pdc>; > >Sorry for not seeing this earlier, but this should be: > > interrupt-parent = <&pdc>; > Thats right. Thanks for pointing out. >Or as it's not unlikely that clients might use a mix of pdc and non-pdc >interrupts the example could use the form: > > interrupts-extended = <&pdc 2 IRQ_TYPE_LEVEL_HIGH>; > OK. Will add it as another example. >> + interrupt = <2 IRQ_TYPE_LEVEL_HIGH>; >> + }; > Thanks, Lina