From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs Date: Thu, 15 Feb 2018 20:21:41 +0000 Message-ID: <20180215202141.GC23714@codeaurora.org> References: <20180209165735.19151-1-ilina@codeaurora.org> <20180209165735.19151-2-ilina@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40552 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033275AbeBOUVn (ORCPT ); Thu, 15 Feb 2018 15:21:43 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Thomas Gleixner Cc: jason@lakedaemon.net, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org, asathyak@codeaurora.org On Mon, Feb 12 2018 at 13:40 +0000, Thomas Gleixner wrote: >On Fri, 9 Feb 2018, Lina Iyer wrote: >> +enum pdc_irq_config_bits { >> + PDC_POLARITY_LOW = 0, >> + PDC_FALLING_EDGE = 2, >> + PDC_POLARITY_HIGH = 4, >> + PDC_RISING_EDGE = 6, >> + PDC_DUAL_EDGE = 7, > >My previous comment about using binary constants still stands. Please >either address review comments or reply at least. Ignoring reviews is not >an option. > >Aside of that I really have to ask about the naming of these constants. Are >these names hardware register nomenclature? If yes, they are disgusting. If >no, they are still disgusting, but should be changed to sensible ones, >which just match the IRQ_TYPE naming convention. > > PDC_LEVEL_LOW = 000b, > PDC_EDGE_FALLING = 010b, > .... > > Checkpatch doesn't like binary constants. I guess I will need to keep the enum definitions in hex or decimal. I will remove the binary from the comments though. commit 95e2c6023b0e4c8499fb521697f79215f69135fe Author: Joe Perches Date: Wed Jul 3 15:05:20 2013 -0700 checkpatch: warn when using gcc's binary constant ("0b") extension The gcc extension for binary constants that start with 0b is only supported with gcc version 4.3 or higher. The kernel can still be compiled with earlier versions of gcc, so have checkpatch emit a warning for these constants. Restructure checkpatch's constant finding code a bit to support finding these binary constants. Signed-off-by: Joe Perches Suggested-by: Andrew Morton Cc: Andy Whitcroft Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Thanks, Lina