From: Jordan Crouse <jcrouse@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: nm@ti.com, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sboyd@codeaurora.org,
dri-devel@lists.freedesktop.org, vireshk@kernel.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/msm: Add A6XX device support
Date: Mon, 5 Mar 2018 08:26:32 -0700 [thread overview]
Message-ID: <20180305152632.GB15200@jcrouse-lnx.qualcomm.com> (raw)
In-Reply-To: <20180305043938.GB23018@vireshk-i7>
On Mon, Mar 05, 2018 at 10:09:38AM +0530, Viresh Kumar wrote:
> On 02-03-18, 14:43, Jordan Crouse wrote:
> > +static int a6xx_gmu_build_freq_table(struct device *dev, unsigned long *freqs,
> > + u32 size)
> > +{
> > + int count = dev_pm_opp_get_opp_count(dev);
> > + struct dev_pm_opp *opp;
> > + int i, index = 0;
> > + unsigned long freq = 1;
> > +
> > + /*
> > + * The OPP table doesn't contain the "off" frequency level so we need to
> > + * add 1 to the table size to account for it
> > + */
> > +
> > + if (WARN(count + 1 > size,
> > + "The GMU frequency table is being truncated\n"))
> > + count = size - 1;
> > +
> > + /* Set the "off" frequency */
> > + freqs[index++] = 0;
> > +
> > + for (i = 0; i < count; i++) {
> > + opp = dev_pm_opp_find_freq_ceil(dev, &freq);
> > + if (IS_ERR(opp))
> > + break;
> > +
> > + freqs[index++] = freq++;
>
> dev_pm_opp_put(opp) ?
>
Yes! Thank you for finding that. I'll fix it in the next go-around.
Jordan
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-05 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 21:43 [v3 PATCH 0/3] Add support for Adreno a6xx Jordan Crouse
[not found] ` <20180302214329.1086-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-02 21:43 ` [PATCH 1/3] PM / OPP: Add dev_pm_opp_get_np() Jordan Crouse
[not found] ` <20180302214329.1086-2-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-05 4:37 ` Viresh Kumar
2018-03-05 15:25 ` Jordan Crouse
2018-03-02 21:43 ` [PATCH 2/3] drm/msm: Add generated headers for A6XX Jordan Crouse
2018-03-02 21:43 ` [PATCH 3/3] drm/msm: Add A6XX device support Jordan Crouse
[not found] ` <20180302214329.1086-4-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-05 4:39 ` Viresh Kumar
2018-03-05 15:26 ` Jordan Crouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-04 16:55 [v4 0/3] Add support for Adreno a6xx Jordan Crouse
[not found] ` <20180604165514.1226-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-06-04 16:55 ` [PATCH 3/3] drm/msm: Add A6XX device support Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305152632.GB15200@jcrouse-lnx.qualcomm.com \
--to=jcrouse@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox