From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi S <sibis@codeaurora.org>
Cc: p.zabel@pengutronix.de, robh+dt@kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, georgi.djakov@linaro.org,
jassisinghbrar@gmail.com, ohad@wizery.com, mark.rutland@arm.com,
kyan@codeaurora.org, sricharan@codeaurora.org,
akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org,
tsoni@codeaurora.org
Subject: Re: [PATCH v3 4/7] mailbox: Add support for Qualcomm SDM845 SoCs
Date: Thu, 19 Apr 2018 10:22:49 -0700 [thread overview]
Message-ID: <20180419172249.GY18510@minitux> (raw)
In-Reply-To: <1521019283-32212-5-git-send-email-sibis@codeaurora.org>
On Wed 14 Mar 02:21 PDT 2018, Sibi S wrote:
> Add the corresponding APCS offset for SDM845 SoC
>
> Signed-off-by: Sibi S <sibis@codeaurora.org>
Full name please.
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 57bde0d..62d704d 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -125,6 +125,7 @@ static int qcom_apcs_ipc_remove(struct platform_device *pdev)
> static const struct of_device_id qcom_apcs_ipc_of_match[] = {
> { .compatible = "qcom,msm8916-apcs-kpss-global", .data = (void *)8 },
> { .compatible = "qcom,msm8996-apcs-hmss-global", .data = (void *)16 },
> + { .compatible = "qcom,sdm845-apcs-hmss-global", .data = (void *)12 },
The block seems to be called "apss shared", so make the compatible
"qcom,sdm845-apss-shared".
Please resubmit this patch separate from the others in the series, as
they can be merged independently of the rest of the series.
PS. For updates like this you can generally submit the dt and code
together.
Regards,
Bjorn
next prev parent reply other threads:[~2018-04-19 17:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 9:21 [PATCH v3 0/7] Add support for remoteproc modem-pil on SDM845 SoCs Sibi S
2018-03-14 9:21 ` [PATCH v3 1/7] dt-bindings: reset: Add AOSS reset bindings for " Sibi S
2018-03-18 12:49 ` Rob Herring
2018-03-18 22:44 ` Bjorn Andersson
2018-03-21 6:29 ` Sibi S
2018-03-14 9:21 ` [PATCH v3 2/7] reset: qcom: AOSS (always on subsystem) reset controller Sibi S
2018-03-14 10:48 ` Vivek Gautam
2018-03-18 22:45 ` Bjorn Andersson
2018-03-22 22:32 ` Sibi S
2018-03-14 9:21 ` [PATCH v3 3/7] dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs Sibi S
2018-03-18 22:45 ` Bjorn Andersson
2018-03-14 9:21 ` [PATCH v3 4/7] mailbox: Add support for Qualcomm " Sibi S
2018-03-18 22:45 ` Bjorn Andersson
2018-04-19 17:22 ` Bjorn Andersson [this message]
2018-03-14 9:21 ` [PATCH v3 5/7] dt-bindings: remoteproc: Add Q6v5 Modem PIL binding for SDM845 Sibi S
2018-03-18 22:46 ` Bjorn Andersson
2018-03-14 9:21 ` [PATCH v3 6/7] remoteproc: qcom: Add support for mss remoteproc on SDM845 Sibi S
2018-03-14 9:21 ` [PATCH v3 7/7] remoteproc: qcom: Always assert and deassert reset signals in SDM845 Sibi S
2018-03-18 22:46 ` Bjorn Andersson
2018-03-22 22:10 ` Sibi S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419172249.GY18510@minitux \
--to=bjorn.andersson@linaro.org \
--cc=akdwived@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=kyan@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).