From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 4/6] soc: qcom: smem: fix off-by-one error in qcom_smem_alloc_private() Date: Tue, 24 Apr 2018 21:48:26 -0700 Message-ID: <20180425044826.GH2052@tuxbook-pro> References: <20180410222542.29474-1-elder@linaro.org> <20180410222542.29474-5-elder@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180410222542.29474-5-elder@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Alex Elder Cc: andy.gross@linaro.org, clew@codeaurora.org, aneela@codeaurora.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Tue 10 Apr 15:25 PDT 2018, Alex Elder wrote: > It's OK if the space for a newly-allocated uncached entry actually > touches the free cached space boundary. It's only a problem if it > would cross it. > > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/soc/qcom/smem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index 82f0908b90e1..0ed263055988 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -375,7 +375,7 @@ static int qcom_smem_alloc_private(struct qcom_smem *smem, > > /* Check that we don't grow into the cached region */ > alloc_size = sizeof(*hdr) + ALIGN(size, 8); > - if ((void *)hdr + alloc_size >= cached) { > + if ((void *)hdr + alloc_size > cached) { > dev_err(smem->dev, "Out of memory\n"); > return -ENOSPC; > } > -- > 2.14.1 >