From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, bjorn.andersson@linaro.org,
andy.gross@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com, aneela@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, clew@codeaurora.org
Subject: Re: [PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink
Date: Fri, 27 Apr 2018 09:24:21 +0800 [thread overview]
Message-ID: <201804270908.gvoFdL1v%fengguang.wu@intel.com> (raw)
In-Reply-To: <1524708472-18263-7-git-send-email-clew@codeaurora.org>
Hi Chris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v4.17-rc2 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Lew/Add-chrdev-and-name-query-support-for-GLINK/20180427-023202
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/rpmsg/qcom_glink_native.c:624:16: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [usertype] id @@ got short [unsigned] [usertype] id @@
drivers/rpmsg/qcom_glink_native.c:624:16: expected unsigned short [unsigned] [usertype] id
drivers/rpmsg/qcom_glink_native.c:624:16: got restricted __le16 [usertype] <noident>
drivers/rpmsg/qcom_glink_native.c:625:18: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [usertype] lcid @@ got short [unsigned] [usertype] lcid @@
drivers/rpmsg/qcom_glink_native.c:625:18: expected unsigned short [unsigned] [usertype] lcid
drivers/rpmsg/qcom_glink_native.c:625:18: got restricted __le16 [usertype] <noident>
drivers/rpmsg/qcom_glink_native.c:626:19: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] count @@ got ed int [unsigned] [usertype] count @@
drivers/rpmsg/qcom_glink_native.c:626:19: expected unsigned int [unsigned] [usertype] count
drivers/rpmsg/qcom_glink_native.c:626:19: got restricted __le32 [usertype] <noident>
drivers/rpmsg/qcom_glink_native.c:627:18: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] size @@ got ed int [unsigned] [usertype] size @@
drivers/rpmsg/qcom_glink_native.c:627:18: expected unsigned int [unsigned] [usertype] size
drivers/rpmsg/qcom_glink_native.c:627:18: got restricted __le32 [usertype] <noident>
drivers/rpmsg/qcom_glink_native.c:628:18: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] liid @@ got ed int [unsigned] [usertype] liid @@
drivers/rpmsg/qcom_glink_native.c:628:18: expected unsigned int [unsigned] [usertype] liid
drivers/rpmsg/qcom_glink_native.c:628:18: got restricted __le32 [usertype] <noident>
>> drivers/rpmsg/qcom_glink_native.c:1569:1: sparse: incorrect type in initializer (different modifiers) @@ expected struct attribute **attrs @@ got structstruct attribute **attrs @@
drivers/rpmsg/qcom_glink_native.c:1569:1: expected struct attribute **attrs
drivers/rpmsg/qcom_glink_native.c:1569:1: got struct attribute const **<noident>
In file included from include/linux/kobject.h:20:0,
from include/linux/irqdesc.h:6,
from include/linux/irq.h:517,
from arch/x86/include/asm/hardirq.h:6,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from drivers/rpmsg/qcom_glink_native.c:15:
drivers/rpmsg/qcom_glink_native.c:1569:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
ATTRIBUTE_GROUPS(qcom_glink);
^
include/linux/sysfs.h:154:11: note: in definition of macro 'ATTRIBUTE_GROUPS'
.attrs = _name##_attrs, 31- ^~~~~
drivers/rpmsg/qcom_glink_native.c:1569:18: note: (near initialization for 'qcom_glink_group.attrs')
ATTRIBUTE_GROUPS(qcom_glink);
^
include/linux/sysfs.h:154:11: note: in definition of macro 'ATTRIBUTE_GROUPS'
.attrs = _name##_attrs, 37- ^~~~~
cc1: some warnings being treated as errors
vim +1569 drivers/rpmsg/qcom_glink_native.c
1564
1565 static const struct attribute *qcom_glink_attrs[] = {
1566 &dev_attr_rpmsg_name.attr,
1567 NULL
1568 };
> 1569 ATTRIBUTE_GROUPS(qcom_glink);
1570
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2018-04-27 1:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 2:07 [PATCH v2 0/6] Add chrdev and name query support for GLINK Chris Lew
2018-04-26 2:07 ` [PATCH v2 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings Chris Lew
2018-04-26 2:07 ` [PATCH v2 2/6] rpmsg: glink: Store edge name for glink device Chris Lew
2018-04-26 2:07 ` [PATCH v2 3/6] rpmsg: glink: Use complete_all for open states Chris Lew
2018-04-26 2:07 ` [PATCH v2 4/6] rpmsg: Guard against null endpoint ops in destroy Chris Lew
2018-04-26 2:07 ` [PATCH v2 5/6] rpmsg: glink: Add support for rpmsg glink chrdev Chris Lew
2018-04-26 2:07 ` [PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink Chris Lew
2018-04-26 22:15 ` kbuild test robot
2018-04-27 0:10 ` kbuild test robot
2018-04-27 1:24 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201804270908.gvoFdL1v%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).