Re: [PATCH v4 1/3] drm/bridge: add support for sn65dsi86 bridge driver

From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ryadav-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	Sandeep Panda <spanda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	kbuild-all-JC7UmRfGjtg@public.gmane.org,
	hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH v4 1/3] drm/bridge: add support for sn65dsi86 bridge driver
Date: Mon, 30 Apr 2018 10:14:01 +0800	[thread overview]
Message-ID: <201804300831.9tSwMuLI%fengguang.wu@intel.com> (raw)
In-Reply-To: <1524821982-2778-2-git-send-email-spanda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2397 bytes --]

Hi Sandeep,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.17-rc3 next-20180426]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sandeep-Panda/Add-suppport-for-sn65dsi86-bridge-chip-and-Innolux-2k-edp-panel/20180430-035839
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: openrisc-allyesconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/ti-sn65dsi86.c: In function 'ti_sn_bridge_connector_get_modes':
>> drivers/gpu/drm/bridge/ti-sn65dsi86.c:173:2: error: implicit declaration of function 'drm_edid_to_eld' [-Werror=implicit-function-declaration]
     drm_edid_to_eld(connector, edid);
     ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/drm_edid_to_eld +173 drivers/gpu/drm/bridge/ti-sn65dsi86.c

   148	
   149	static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector)
   150	{
   151		struct ti_sn_bridge *pdata = connector_to_ti_sn_bridge(connector);
   152		struct drm_panel *panel = pdata->panel;
   153		struct edid *edid;
   154	
   155		if (panel) {
   156			DRM_DEBUG("get mode from connected drm_panel\n");
   157			pdata->num_modes = drm_panel_get_modes(panel);
   158			return pdata->num_modes;
   159		}
   160	
   161		/* get from EDID */
   162		if (!pdata->ddc)
   163			return 0;
   164	
   165		ti_sn_bridge_power_ctrl(pdata, true);
   166		edid = drm_get_edid(connector, pdata->ddc);
   167		ti_sn_bridge_power_ctrl(pdata, false);
   168		if (!edid)
   169			return 0;
   170	
   171		drm_mode_connector_update_edid_property(connector, edid);
   172		pdata->num_modes = drm_add_edid_modes(connector, edid);
 > 173		drm_edid_to_eld(connector, edid);
   174		kfree(edid);
   175	
   176		return pdata->num_modes;
   177	}
   178	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44663 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno